Conversation
…verity or an owner We assume someone is already working on them and thus skip the triage
Contributor
Author
|
The severity check does most of the heavy lifting here. If a patch is already on a bug or assigned, it almost always also has a severity attached. |
marco-c
reviewed
Sep 16, 2026
Comment on lines
+154
to
+155
| def test_queries_only_bugs_with_no_severity_yet(): | ||
| assert _rule().get_bz_params("2026-07-28")["bug_severity"] == "--" |
Contributor
There was a problem hiding this comment.
I'd remove these tests that are simply assertions on the code itself, they are not checking behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We assume someone is already working on them and thus skip the triage