Bug 2034534 - Use glean-sym to record a metric from places Rust implementation#7336
Bug 2034534 - Use glean-sym to record a metric from places Rust implementation#7336badboy wants to merge 1 commit into
Conversation
bendk
left a comment
There was a problem hiding this comment.
This looks great to me and the plan of using Glean main for a bit is totally fine with me. The Rust changes look great, I'm excited to start using code like that myself.
|
DATA REVIEW REQUEST
We're introducing a new Rust API to be used across libraries and we need to ensure it works as expected.
This is using a new API and the metrics are used for validation.
TODO: Fill this in.
This collection is Glean so is documented in the Glean Dictionary.
This collection has expiry '2026-11-13', 6 months after the metrics are added.
All channels, countries, and locales. No filters.
These collections are Glean. The opt-out can be found in the product's preferences.
We use these metrics to validate that glean-sym works as expected and compare their values against the original metrics.
The analysis will be shared in a public bugzilla bug, and the analysis queries will be linked.
No. data-review? @travis79 |
travis79
left a comment
There was a problem hiding this comment.
Data review only:
DATA REVIEW REQUEST
1. What questions will you answer with this data? * Is `glean-sym` working when called from appservices * Are the values comparable to the original metrics? 2. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?We're introducing a new Rust API to be used across libraries and we need to ensure it works as expected.
3. What alternative methods did you consider to answer these questions? Why were they not sufficient?This is using a new API and the metrics are used for validation.
4. Can current instrumentation answer these questions?TODO: Fill this in.
5. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories found on the Mozilla wiki.Measurement Name Measurement Description Data Collection Category Tracking Bug
places_manager.connection_initializedNumber of times aPlacesConnectionwas initialized. technical https://bugzilla.mozilla.org/show_bug.cgi?id=2034534
places_manager.run_maintenance_chk_pnt_time_tempTime taken to executePRAGMA_CHECKPOINTinsiderun_maintenance()Duplication ofrun_maintenance_chk_pnt_time_tempfor glean-sym testing. technical https://bugzilla.mozilla.org/show_bug.cgi?id=2034534
places_manager.run_maintenance_optimize_time_tempTime taken to executePRAGMA optimizeinsiderun_maintenance()Duplication ofrun_maintenance_optimize_timefor glean-sym testing. technical https://bugzilla.mozilla.org/show_bug.cgi?id=2034534
places_manager.run_maintenance_prune_time_tempTime taken to executeprune_older_visits()insiderun_maintenance()Duplication ofrun_maintenance_prune_timefor glean-sym testing. technical https://bugzilla.mozilla.org/show_bug.cgi?id=2034534
places_manager.run_maintenance_vacuum_time_tempTime taken to executeVACUUMinsiderun_maintenance()Duplication ofrun_maintenance_vacuum_timefor glean-sym testing. technical https://bugzilla.mozilla.org/show_bug.cgi?id=20345346. Please provide a link to the documentation for this data collection which describes the ultimate data set in a public, complete, and accurate way.This collection is Glean so is documented in the Glean Dictionary.
7. How long will this data be collected?This collection has expiry '2026-11-13', 6 months after the metrics are added.
8. What populations will you measure?All channels, countries, and locales. No filters.
9. If this data collection is default on, what is the opt-out mechanism for users?These collections are Glean. The opt-out can be found in the product's preferences.
10. Please provide a general description of how you will analyze this data.We use these metrics to validate that glean-sym works as expected and compare their values against the original metrics. Analysis will be done in sql.telemetry.mozilla.org
11. Where do you intend to share the results of your analysis?The analysis will be shared in a public bugzilla bug, and the analysis queries will be linked.
12. Is there a third-party tool (i.e. not Glean or Telemetry) that you are proposing to use for this data collection?No.
data-review? @travis79
Data Review Form
- Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
Yes, through the Glean Dictionary
- Is there a control mechanism that allows the user to turn the data collection on and off?
Yes, through the data-collection settings in the embedding application
- If the request is for permanent data collection, is there someone who will monitor the data over time?
N/A, collection set to expire in 6 months
- Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
Category 1, Technical Data
- Is the data collection request for default-on or default-off?
Default-on
- Does the instrumentation include the addition of any new identifiers?
No
- Is the data collection covered by the existing Firefox privacy notice?
Yes
- Does the data collection use a third-party collection tool?
No
Result
data-review+
|
This still need another update: we need to restrict it to Android builds, the only build where we can ensure libxul will be available in production. |
This is not yet ready (I need to actually properly test it and also decide if those are the right metrics), but this is how I expect it to look.
Currently building against mozilla/glean#3426
The plan is to land that and a-s can depend on the git version (what is on
main) by then.