Skip to content

Add Enterprise Channel in DevHub#25160

Open
chrstinalin wants to merge 1 commit into
mozilla:masterfrom
chrstinalin:#14849-enterprise-channel
Open

Add Enterprise Channel in DevHub#25160
chrstinalin wants to merge 1 commit into
mozilla:masterfrom
chrstinalin:#14849-enterprise-channel

Conversation

@chrstinalin

@chrstinalin chrstinalin commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Relates to mozilla/addons#14849

Description

Adds an Enterprise channel to Devhub.

image image

Testing

Enable the enterprise-channel waffle switch.

Themes

  1. Themes cannot/do not have the enterprise option.

Extensions

  1. Create an enterprise extension (i.e has browser_specific_settings: { gecko: { admin_install_only: true } } in its manifest). On lint, listed/unlisted channels should reject this add-on. The enterprise channel requires it.

  2. The source code submission page is skipped for enterprise add-ons.

  3. The add-on is subject to automatic approval and not flagged for human review.

  4. Has a review page but no listing page, similar to unlisted.

  5. Once the enterprise channel is used, new versions must also use the enterprise channel (i.e cannot be listed or unlisted). The user does not have the option to use listed or unlisted.

  6. Vice versa, when listed/unlisted are used, the enterprise channel is no longer available. (See: Block Non-Enterprise Versions when Enterprise Version is Uploaded #25186 for replacement)

Checklist

  • Add #ISSUENUM at the top of your PR to an existing open issue in the mozilla/addons repository.
  • Successfully verified the change locally.
  • The change is covered by automated tests, or otherwise indicated why doing so is unnecessary/impossible.
  • Add before and after screenshots (Only for changes that impact the UI).

@chrstinalin
chrstinalin marked this pull request as draft July 17, 2026 18:50
@chrstinalin
chrstinalin force-pushed the #14849-enterprise-channel branch 6 times, most recently from 85cc625 to 48b5530 Compare July 21, 2026 20:48
@chrstinalin
chrstinalin requested review from a team and nothingrandom and removed request for a team July 22, 2026 15:55
Comment thread src/olympia/devhub/forms.py Outdated
Comment on lines +1440 to +1442
'Firefox for Enterprise policy. Note that this will block any existing '
'listed and unlisted versions after 90 days, and you will no longer be '
'able to upload new listed or unlisted versions.</span>'

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[query]

From the PRD

Once the enterprise channel is used for an add-on, block listed and unlisted versions for that add-on automatically after 90 days. This should be called out in the UI when selecting the enterprise channel for the first time.

The comments on this item, also suggest an unresolved conversation of a) is this correct or b) should a user only be able to select enterprise on first submission (denying any migration of existing)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wagnerand-moz Do you have any thoughts on this?

@chrstinalin chrstinalin Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In terms of "for the first time," I'm wondering if it's worth adding the extra query to do this. I can't think of any cons to simply stating it in the description off the top of my head (especially since hard blocking all existing versions is a pretty big action, and not something that I imagine should be easily dismissed)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That entire bit about automatically blocking listed & unlisted versions after 90 days and preventing use of these channels is relatively new (was added July 6th while I was out) and wasn't there when I put the ticket in the sprint - given it's a "should have", I would rather do that separately, I'm not sure it's worth the added complexity.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comments on this item, also suggest an unresolved conversation of a) is this correct or b) should a user only be able to select enterprise on first submission (denying any migration of existing)

That's a great question. In a meeting, I had suggested (a) as one option, not necessarily the solution; Also, it was added to the PRD only recently. There are pros and cons for each. For example, (b) would be cleaner, but then we need to figure out how and support developers on migrating from add-on to another in Firefox. However, I am not sure that is an actual concern for add-ons installed through enterprise policies.

I don't have a great answer for you right now and it might make sense to check in with Alan when he's back but I assume the PR is blocked on this question? If you prefer, we could move forward with (a) (because it's stated in the PRD), with the caveat that we might change the approach.

@chrstinalin chrstinalin Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll split it out into a separate PR for now.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sgtm

Comment thread static/css/devhub/listing.less Outdated
Comment thread static/css/zamboni/developers.css Outdated
Comment thread static/css/zamboni/reviewers.less Outdated
Comment thread src/olympia/versions/models.py Outdated
@nothingrandom
nothingrandom requested a review from diox July 23, 2026 13:06
@nothingrandom

Copy link
Copy Markdown
Member

Adding @diox as a reviewer, as this epic has history from before I joined that I want to ensure is covered in the review

@chrstinalin
chrstinalin marked this pull request as ready for review July 23, 2026 13:08
@chrstinalin
chrstinalin force-pushed the #14849-enterprise-channel branch 2 times, most recently from 7612931 to 37eebb8 Compare July 23, 2026 15:24
@chrstinalin
chrstinalin force-pushed the #14849-enterprise-channel branch from 37eebb8 to 37d748f Compare July 23, 2026 15:46
@chrstinalin

Copy link
Copy Markdown
Contributor Author

Separate (draft, until this one is merged) PR for blocks here: #25186

In the meantime, I've prevented add-ons with existing listed/unlisted from uploading via the enterprise channel (which is also the other option Andreas provided in the PRD, and further discussed here)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants