Add Enterprise Channel in DevHub#25160
Conversation
85cc625 to
48b5530
Compare
| 'Firefox for Enterprise policy. Note that this will block any existing ' | ||
| 'listed and unlisted versions after 90 days, and you will no longer be ' | ||
| 'able to upload new listed or unlisted versions.</span>' |
There was a problem hiding this comment.
[query]
From the PRD
Once the enterprise channel is used for an add-on, block listed and unlisted versions for that add-on automatically after 90 days. This should be called out in the UI when selecting the enterprise channel for the first time.
The comments on this item, also suggest an unresolved conversation of a) is this correct or b) should a user only be able to select enterprise on first submission (denying any migration of existing)
There was a problem hiding this comment.
@wagnerand-moz Do you have any thoughts on this?
There was a problem hiding this comment.
In terms of "for the first time," I'm wondering if it's worth adding the extra query to do this. I can't think of any cons to simply stating it in the description off the top of my head (especially since hard blocking all existing versions is a pretty big action, and not something that I imagine should be easily dismissed)
There was a problem hiding this comment.
That entire bit about automatically blocking listed & unlisted versions after 90 days and preventing use of these channels is relatively new (was added July 6th while I was out) and wasn't there when I put the ticket in the sprint - given it's a "should have", I would rather do that separately, I'm not sure it's worth the added complexity.
There was a problem hiding this comment.
The comments on this item, also suggest an unresolved conversation of a) is this correct or b) should a user only be able to select enterprise on first submission (denying any migration of existing)
That's a great question. In a meeting, I had suggested (a) as one option, not necessarily the solution; Also, it was added to the PRD only recently. There are pros and cons for each. For example, (b) would be cleaner, but then we need to figure out how and support developers on migrating from add-on to another in Firefox. However, I am not sure that is an actual concern for add-ons installed through enterprise policies.
I don't have a great answer for you right now and it might make sense to check in with Alan when he's back but I assume the PR is blocked on this question? If you prefer, we could move forward with (a) (because it's stated in the PRD), with the caveat that we might change the approach.
There was a problem hiding this comment.
I'll split it out into a separate PR for now.
|
Adding @diox as a reviewer, as this epic has history from before I joined that I want to ensure is covered in the review |
7612931 to
37eebb8
Compare
37eebb8 to
37d748f
Compare
Relates to mozilla/addons#14849
Description
Adds an Enterprise channel to Devhub.
Testing
Enable the
enterprise-channelwaffle switch.Themes
Extensions
Create an enterprise extension (i.e has
browser_specific_settings: { gecko: { admin_install_only: true } } in its manifest). On lint, listed/unlisted channels should reject this add-on. The enterprise channel requires it.The source code submission page is skipped for enterprise add-ons.
The add-on is subject to automatic approval and not flagged for human review.
Has a review page but no listing page, similar to unlisted.
Once the enterprise channel is used, new versions must also use the enterprise channel (i.e cannot be listed or unlisted). The user does not have the option to use listed or unlisted.
Vice versa, when listed/unlisted are used, the enterprise channel is no longer available. (See: Block Non-Enterprise Versions when Enterprise Version is Uploaded #25186 for replacement)
Checklist
#ISSUENUMat the top of your PR to an existing open issue in the mozilla/addons repository.