rm PROMOTED_GROUP_CHOICES#25106
Merged
eviljeff merged 16 commits intoJul 22, 2026
Merged
Conversation
WIP TODO: filters.py changes are lacking - need way to replicate badged
eviljeff
force-pushed
the
15976-rm-promoted-group-choices-references
branch
2 times, most recently
from
July 7, 2026 11:57
657bb5d to
16a4768
Compare
eviljeff
force-pushed
the
15976-rm-promoted-group-choices-references
branch
from
July 7, 2026 15:06
16a4768 to
8c43966
Compare
eviljeff
marked this pull request as ready for review
July 7, 2026 17:25
eviljeff
changed the title
eviljeff
force-pushed
the
15976-rm-promoted-group-choices-references
branch
from
July 8, 2026 10:36
21c7d2a to
ed8041a
Compare
eviljeff
requested review from
a team and
chrstinalin
and removed request for
a team
July 8, 2026 11:41
chrstinalin
reviewed
Jul 8, 2026
chrstinalin
approved these changes
Jul 20, 2026
This was referenced Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes mozilla/addons#15976
Description
Removes PROMOTED_GROUP_CHOICES from live and test code. Also drops
Addons:RecommendedReviewpermission.Context
Almost the last part of removing all constants relating to Promoted groups - with the aim that PromotedGroups can be added and edited freely in production without code changes or migrations.
Almost, because we still need to know what
badgedgroup means, without the database; and addons-frontend still has some hard-coded constants controlling the behavior of the groups it knows about.I made the changes in code, and had claude update the tests.
Testing
Checklist
#ISSUENUMat the top of your PR to an existing open issue in the mozilla/addons repository.