Implement decision overrides in reviewer tools#25075
Merged
eviljeff merged 5 commits intoJul 22, 2026
Merged
Conversation
eviljeff
force-pushed
the
16242-reviewer-tools-override-decision
branch
from
June 29, 2026 10:57
ab458e8 to
31b398c
Compare
eviljeff
force-pushed
the
16242-reviewer-tools-override-decision
branch
from
June 29, 2026 15:00
31b398c to
e9781d5
Compare
Member
I don't think that should be possible/allowed. If the add-on itself was disabled, we shouldn't allow an approve version, the force-disable should be reverted first separately. |
This comment was marked as outdated.
This comment was marked as outdated.
eviljeff
force-pushed
the
16242-reviewer-tools-override-decision
branch
3 times, most recently
from
July 2, 2026 17:38
40c9d36 to
acc175f
Compare
eviljeff
marked this pull request as ready for review
July 3, 2026 08:37
eviljeff
force-pushed
the
16242-reviewer-tools-override-decision
branch
from
July 3, 2026 16:18
805dd3f to
bc285a7
Compare
eviljeff
marked this pull request as draft
July 13, 2026 10:40
eviljeff
force-pushed
the
16242-reviewer-tools-override-decision
branch
4 times, most recently
from
July 14, 2026 12:38
96504f9 to
a6fd11f
Compare
eviljeff
force-pushed
the
16242-reviewer-tools-override-decision
branch
from
July 14, 2026 12:51
a6fd11f to
12664d9
Compare
eviljeff
marked this pull request as ready for review
July 14, 2026 15:01
1 task
diox
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes mozilla/addons#16242
Description
When making a new decision, optionally allows selecting an existing decision to be overridden. When this happens the enforcement action for the existing decision is reversed first.
For complex cases where the decision to be overridden needs to be reversed first, there is an "Override Reverse-only" policy for the first override.Selecting a previous decision to override also force-shows (unhides) the versions that were affected by that decision, meaning you can choose versions to be affected by the new decision even if their status would usually hide them.
Context
Turned out to be quite a large pr! Properly overriding involved a lot of changes - really the PR is much more about ActionClass changes and not much in the reviewer tools code. The reviewer tools changes are mainly about exposing the versions affected by the overridden decision.
I had claude write the refactoring changes with overrides in abuse/actions.py, abuse/models.py, and the associated tests. I read all the changes, and they seem reasonable, but worth paying special attention nevertheless. I then followed up that refactoring with some manual clean-up and fixes.
Testing
Sync your Cinder policies + turn on waffle switch + enable the new Override Reverse-only for reviewer tools in django admin
Try:
overriding to Override Reverse-only policy - shouldn't send an emailthen overriding that override to a new decision (should sent an email)Checklist
#ISSUENUMat the top of your PR to an existing open issue in the mozilla/addons repository.