Repository navigation
File bugs in Core :: General when the moz.yaml's component doesn't exist - #434
Merged
Merged
Conversation
If the bugzilla component in a library's moz.yaml doesn't exist, Bugzilla rejects the bug (code 51, "There is no component named ...") and we crashed without filing anything. On the dev instance this hit seven libraries whose components only exist in production. File the bug in Core :: General instead, then file a bug in Updatebot's component asking for the moz.yaml to be fixed, blocking the first one and needinfo-ing tom and the library's maintainer. If filing that second bug fails, log it and carry on rather than losing track of the library's bug.
There was a problem hiding this comment.
🟡 Changes recommended
Follow-up bugs do not preserve confidentiality, exposing associations between libraries and restricted commit-alert bugs.
1 open issue
What changed in this PR
Adds fallback filing when a library’s configured Bugzilla component does not exist.
Changes:
- Retries filing in Core :: General and creates a linked configuration-repair bug.
- Allows repair bugs to omit Firefox affected-status fields.
- Tests fallback filing and repair-bug failure handling.
| File | Description |
|---|---|
| tests/bugzilla.py | Tests missing-component fallback and follow-up failures. |
| components/bugzilla.py | Adds fallback filing and configuration-repair notifications. |
| apis/bugzilla_api.py | Makes affected-status marking optional. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the bugzilla component in a library's moz.yaml doesn't exist, Bugzilla rejects the bug (code 51, "There is no component named ...") and we crashed without filing anything. On the dev instance this hit seven libraries whose components only exist in production.
File the bug in Core :: General instead, then file a bug in Updatebot's component asking for the moz.yaml to be fixed, blocking the first one and needinfo-ing tom and the library's maintainer. If filing that second bug fails, log it and carry on rather than losing track of the library's bug.