Repository navigation
Proxy engine: persistent CA, capped capture, upgrade tunnel - #750
Merged
Merged
Conversation
gschier
marked this pull request as ready for review
October 14, 2026 17:30
[High impact] The PR appears safe to merge, with no new actionable issues or outstanding previous findings. SummaryThe PR adds a saved CA, streamed body capture with a size cap, and blind tunnels for upgrades and traffic that cannot be inspected.
|
Member
Author
|
@greptileai review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First engine PR for Yaak Proxy (
crates/yaak-proxy).CaStore::load_or_create(dir)persists the CA (ca.pem,ca.keyat 0600, CN "Yaak Proxy CA", 10 years). Leaf certs are 365 days with serverAuth EKU, picked by SNI.start_proxy(ProxyConfig { port, ca, capture_body_limit, upstream_root_certs }). Client-facing ALPN is http/1.1 only; upstream still negotiates h2 or h1.RequestBodyChunk/ResponseBodyChunkevents carry each frame's bytes up to the cap (10 MB default); completion events carry size,truncated, timing and error. The engine stores nothing.Upgraderequests inside CONNECT are spliced into a blind tunnel after the 101. Non-TLS CONNECT payloads, and hosts whose client rejected the TLS handshake (pinning), are tunneled without interception.started_at, elapsed to headers and to end, sizes, HTTP versions on both sides, remote address, error.logreplaceseprintln!.yaak-proxy-libis only adapted to the new API.CI already builds
yaak-app-proxy(cargo test --all) and type-checksapps/yaak-proxy(npm run lint), soci.ymlis unchanged.Tests (
cargo test -p yaak-proxy), against a local HTTPS server signed by a throwaway CA:Errorevent