Skip to content

impr(input-indicator): add input indicator to all fields with validators (@Leonabcd123)#7918

Merged
Miodec merged 3 commits into
monkeytypegame:masterfrom
Leonabcd123:fix/input-indicator
May 11, 2026
Merged

impr(input-indicator): add input indicator to all fields with validators (@Leonabcd123)#7918
Miodec merged 3 commits into
monkeytypegame:masterfrom
Leonabcd123:fix/input-indicator

Conversation

@Leonabcd123
Copy link
Copy Markdown
Contributor

@Leonabcd123 Leonabcd123 commented May 6, 2026

Remove the showIndicator property from InputField, instead check whether validators exists to decide whether we should show the input indicator.

@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label May 6, 2026
@Leonabcd123 Leonabcd123 changed the title fix(input-indicator): add input indicator to more modals (@Leonabcd123) impr(input-indicator): add input indicator to more modals (@Leonabcd123) May 6, 2026
@fehmer
Copy link
Copy Markdown
Member

fehmer commented May 6, 2026

I havent tested this yet, but maybe we could remove the showIndicatorproperty and check for props.field().options.validatorsto be present?

It is kind of odd to define validations on a field but don't want to show the indicator for it

@Leonabcd123 Leonabcd123 changed the title impr(input-indicator): add input indicator to more modals (@Leonabcd123) impr(input-indicator): add input indicator to all fields with validators (@Leonabcd123) May 7, 2026
@Miodec Miodec merged commit 0c07e10 into monkeytypegame:master May 11, 2026
15 checks passed
@Miodec
Copy link
Copy Markdown
Member

Miodec commented May 11, 2026

Thanks

@Leonabcd123 Leonabcd123 deleted the fix/input-indicator branch May 11, 2026 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend User interface or web stuff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants