fix: Resolve guideline dependency links#116
Open
andmatei wants to merge 3 commits into
Open
Conversation
andmatei
force-pushed
the
andmatei/fix-dependson-links-main
branch
3 times, most recently
from
9a4a812 to
b0ee1d4
Compare
andmatei
force-pushed
the
andmatei/fix-dependson-links-main
branch
from
b0ee1d4 to
5025101
Compare
andmatei
changed the title
- ipaNumber: guard against Number('') === 0 with `&& parsed > 0`
- depHref: apply same-page check in the bare-IPA branch to avoid
unnecessary full-page navigation when depIpa === currentIpa
- depLabel: format bare IPA-NNN refs as "IPA 107" (space) to match
the style of full guideline labels
- slugToTitle: remove dead `|| id` fallback (unreachable since
depLabel guards with hasGuidelineAnchor before calling)
- vitest.setup.ts: return singleton from useBrokenLinks mock so
collectAnchor is the same vi.fn() instance across calls
- Guideline.test.tsx: add test verifying collectAnchor registration
andmatei
requested review from
andreaangiolillo,
drinkbird,
lovisaberggren,
matt-condon,
saisundar,
wtrocki and
yelizhenden-mdb
yelizhenden-mdb
left a comment
yelizhenden-mdb
left a comment
Collaborator
There was a problem hiding this comment.
My understanding: From now on, all the guidelines are linkable via their ids. Clicking a dependsOn link scrolls the referenced guideline into view.
How about indicating which guideline you landed on? When navigating to a guideline via a dependsOn link, the target guideline would be highlighted on arrival, then fade out, so the user can immediately understand to where they jumped. wdyt?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: CLOUDP-416863
Summary
Fixed the links for the guidelines in
dependsOn. Now clicking the links navigates to the referenced guideline / principleValidation
npm testnpm run docusaurus:build