feat(ipa): Clarify cascading guideline for IPA-108#115
Conversation
lovisaberggren
requested review from
andmatei,
andreaangiolillo,
drinkbird,
maks-m-mongo-leaf,
matt-condon,
saisundar and
wtrocki
| { | ||
| "error": 400, | ||
| "reason": "Bad Request", | ||
| "detail": "The request content produced validation errors.", |
There was a problem hiding this comment.
[nit] could you add more descriptive detail message instead?
There was a problem hiding this comment.
Sure, done!
|
|
||
| <Guidelines> | ||
|
|
||
| <Guideline id="IPA-108-must-not-delete-child-resources-by-default" given="delete-operation" enforcement="review" effort="reason"> |
There was a problem hiding this comment.
Do you think this should be an implementation check? If so can we add implementation and make the effort=explore
There was a problem hiding this comment.
Oh yeah that makes sense, I was a bit unsure of the new metadata stuff! But yeah this is definitely something that should be checked from the source code. I'll update it, do you think the validation workflow should also be adjusted a bit perhaps?
There was a problem hiding this comment.
I updated now and adjusted the workflow too, let me know what you think
There was a problem hiding this comment.
That is perfect thank you so much. Also as an FYI the CONTRIBUTING has a bit more details regarding the metadata, feel free to have a look and see if anything is unclear
3 participants
Clarifies the cascading section of IPA-108: Delete by adding new rule that the API must not delete child resource by default when a parent resource is deleted. Sets up the expectation before presenting the cascading flag as rule nr. 2.
Ticket: CLOUDP-417158