Skip to content

feat(parsing): named stringify export - #935

Merged
mabaasit merged 1 commit into
mainfrom
named-parse-export
Oct 27, 2026
Merged

mabaasit merged 1 commit into
mainfrom
named-parse-export

Conversation

@mabaasit

Copy link
Copy Markdown
Collaborator

Exports toJSString separately. Currently the default export pulls in the worker code and it breaks vscode integration. We can fix it on the vscode side using webpack, but this is cleaner.

Description

Open Questions

Checklist

Copilot AI balanced review requested due to automatic review settings October 27, 2026 17:52
@mabaasit
mabaasit requested review from a team as code owners October 27, 2026 17:52
@mabaasit
mabaasit requested a review from paula-stacho October 27, 2026 17:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The additive export and bundle mappings preserve existing entry points, with no unresolved issues identified.

No open issues 🎉

What changed in this PR

Adds a dedicated stringify entry point to shell-bson-parser, allowing VS Code consumers to use toJSString without pulling in worker code.

Changes:

  • Adds subpath exports and TypeScript type mappings while preserving existing root exports.
  • Adds a CommonJS bundle entry for stringify.
  • Adds a test asserting that the stringify module exports only toJSString.
File Description
packages/​shell-bson-parser/​webpack.cjs.config.cjs Builds the standalone CommonJS stringify entry.
packages/​shell-bson-parser/​src/​stringify.spec.ts Checks the stringify module’s export surface.
packages/​shell-bson-parser/​package.json Exposes the stringify subpath and its types.

Review effort: Balanced

@mabaasit
mabaasit enabled auto-merge (squash) October 27, 2026 18:03
@mabaasit
mabaasit disabled auto-merge October 27, 2026 19:39
@mabaasit
mabaasit merged commit 9f4140b into main Oct 27, 2026
33 of 34 checks passed
@mabaasit
mabaasit deleted the named-parse-export branch October 27, 2026 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants