Repository navigation
feat(parsing): named stringify export - #935
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The additive export and bundle mappings preserve existing entry points, with no unresolved issues identified.
No open issues 🎉
What changed in this PR
Adds a dedicated stringify entry point to shell-bson-parser, allowing VS Code consumers to use toJSString without pulling in worker code.
Changes:
- Adds subpath exports and TypeScript type mappings while preserving existing root exports.
- Adds a CommonJS bundle entry for
stringify. - Adds a test asserting that the stringify module exports only
toJSString.
| File | Description |
|---|---|
packages/shell-bson-parser/webpack.cjs.config.cjs |
Builds the standalone CommonJS stringify entry. |
packages/shell-bson-parser/src/stringify.spec.ts |
Checks the stringify module’s export surface. |
packages/shell-bson-parser/package.json |
Exposes the stringify subpath and its types. |
Review effort: Balanced
3 tasks
nbbeeken
approved these changes
Oct 27, 2026
mabaasit
enabled auto-merge (squash)
October 27, 2026 18:03
mabaasit
disabled auto-merge
October 27, 2026 19:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exports
toJSStringseparately. Currently the default export pulls in the worker code and it breaks vscode integration. We can fix it on the vscode side using webpack, but this is cleaner.Description
Open Questions
Checklist