Skip to content

Fix for build on Windows#108

Open
mdhvg wants to merge 1 commit into
monatis:mainfrom
mdhvg:main
Open

Fix for build on Windows#108
mdhvg wants to merge 1 commit into
monatis:mainfrom
mdhvg:main

Conversation

@mdhvg

@mdhvg mdhvg commented Mar 11, 2025

Copy link
Copy Markdown
  • This PR fixes issues in the code that could've lead to undefined behaviours
    • Variable-Length Arrays (VLAs), though supported by GCC and Clang, not recommended for use
float vec[vec_len];
// vec_len being a variable set at runtime.
  • Also, the pthread for windows conversion macro from ggml-org/ggml is added to clip.cpp to enable multi-threading support on Windows.

Comment thread clip.h
@recurseml

recurseml Bot commented Mar 11, 2025

Copy link
Copy Markdown

😱 Found 1 issue. Time to roll up your sleeves! 😱

@monatis

monatis commented Mar 11, 2025

Copy link
Copy Markdown
Owner

Hi @mdhvg, thanks for raising this PR! I'll review it later today and then merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants