Repository navigation
fix(tests,fw): Fill reserve-bal. related coverage gaps, fix impl - #67
Merged
Merged
Conversation
mijovic
approved these changes
Oct 20, 2026
Base automatically changed from
eips/monad_next/eip-7708+7843+7981+7997+8024+8246
to
forks/monad_nine
October 20, 2026 10:16
The short cases fail until the spec checks only the gas fees at inclusion. Co-Authored-By: Claude <claude-fable-5-1>
…lance The client checks only the gas fees at inclusion and fails the top-level frame on the value. Co-Authored-By: Claude <claude-fable-5-1>
The fee-cap cases fail until the inclusion check uses the effective gas price. Co-Authored-By: Claude <claude-fable-5-1>
The client only requires the balance to cover the gas fees it charges, not the max fee per gas. Co-Authored-By: Claude <claude-fable-5-1>
The nonce and missing-contract checks also pass when the create is skipped instead of halting the frame. Co-Authored-By: Claude <claude-fable-5-1>
The in-window cases fail until the spec records every recovered authority. Co-Authored-By: Claude <claude-fable-5-1>
…window The clients mark an authority before any validity check, so a skipped one counts. Co-Authored-By: Claude <claude-fable-5-1>
pdobacz
force-pushed
the
fix/value-above-balance
branch
from
October 20, 2026 10:21
d5506d2 to
1b93e1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to:
Each addition to tests accompanied by fixes to the spec implementation in a separate commit.
NOTE to review: the changes under
src/ethereum/forks...are 4x the same thing for 4 forks (eight->eleven)Based on top of #53, merged that one first


Confidence Score: 5/5
The PR appears safe to merge; no actionable issues were found.Summary
This PR updates Monad Eight through Eleven to check whether a sender can pay the effective gas fee, then fail execution if the remaining balance cannot cover the value sent.
Diagram
%%{init: {'theme': 'neutral'}}%% flowchart TD A[Check transaction] --> B{Balance covers effective gas fees?} B -- No --> C[Reject transaction] B -- Yes --> D[Charge fees and advance sender nonce] D --> E[Record recovered authorization signers] E --> F{Remaining balance covers value?} F -- No --> G[Return failed receipt without running code] F -- Yes --> H[Transfer value and run code] H --> I[Check reserve balance and settle transaction]Reviews (2) · Last reviewed commit: "fix(forks): record every recovered autho..." · Reviewed by Greptile