Skip to content

update(_remap_sfr): add more robust handling for (0, 0, 0) SFR cells - #2840

Draft
jlarsen-usgs wants to merge 5 commits into
modflowpy:developfrom
jlarsen-usgs:develop
Draft

update(_remap_sfr): add more robust handling for (0, 0, 0) SFR cells#2840
jlarsen-usgs wants to merge 5 commits into
modflowpy:developfrom
jlarsen-usgs:develop

Conversation

@jlarsen-usgs

Copy link
Copy Markdown
Contributor
  • add logic to traverse the connectiondata graph to find the nearest
    connected GWF/SFR cell in which (0, 0, 0) cells are routed to

…map_arr to follow new convention

* remove sklearn requirement
* add logic to traverse the connectiondata graph to find the nearest
connected GWF/SFR cell in which (0, 0, 0) cells are routed to
@jlarsen-usgs

Copy link
Copy Markdown
Contributor Author

Will add testing soon to wrap up the development on this PR

@codecov

codecov Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.6%. Comparing base (556c088) to head (789e0b6).
⚠️ Report is 226 commits behind head on develop.

Files with missing lines Patch % Lines
flopy/mf6/utils/model_splitter.py 0.0% 15 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2840      +/-   ##
===========================================
+ Coverage     55.5%    73.6%   +18.0%     
===========================================
  Files          644      659      +15     
  Lines       124135   132300    +8165     
===========================================
+ Hits         68947    97394   +28447     
+ Misses       55188    34906   -20282     
Files with missing lines Coverage Δ
flopy/mf6/utils/model_splitter.py 68.6% <0.0%> (-6.3%) ⬇️

... and 585 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

model splitter SFR NONE/(0,0,0) not always assigned to correct model

1 participant