feat: support container-confinement service keys (read_only, init, privileged, cap_add, cap_drop, security_opt)#24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second Bucket A bundle. Adds six per-container container-confinement keys, each an invariant-preserving
podman runflag with no change to the single-pod model.read_only/init/privileged— booleans, emitted as the bare--read-only/--init/--privilegedflag only when true (new_BOOL_FLAGStable).cap_add/cap_drop/security_opt— lists, emitted as repeated--cap-add/--cap-drop/--security-opt(reuse the existing_LIST_FLAGStable; item contents pass through verbatim,${VAR}-interpolated likegroup_add).Also in this branch:
stop_signal/stop_grace_periodreclassified out of Bucket A and wired intoIGNORED_SERVICE_KEYS(accepted with a warning, not rejected) — they are inert because the generated script force-removes the pod (podman pod rm -f) and never gracefully stops a container.test_unsupported_service_key_raises(and a sibling CLI test) retargeted fromprivileged(now supported) tonetwork_mode(a permanent-reject key).Design and rationale (single home, not restated here):
planning/changes/2026-07-09.04-container-confinement-service-keys.mdplanning/changes/2026-07-09.05-ignore-stop-lifecycle-keys.mdplanning/decisions/2026-07-09-stop-lifecycle-keys-inert.mdBehavior promoted into
architecture/supported-subset.mdin the same PR.Tests: 163 passing at 100% line coverage;
just lint-ciclean.🤖 Generated with Claude Code