feat: support core process/identity service keys (entrypoint, user, working_dir, group_add, labels)#23
Merged
Conversation
run_flags exceeded ruff's complexity (C901) and branch-count (PLR0912) thresholds after recent feature commits added per-service flag loops. Extract the env, volume/tmpfs, and declarative-table (scalar/list/label) emission into their own mutate-in-place helpers, mirroring the existing _add_health_flags pattern. Emitted output and flag order are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds five Bucket A per-container service keys to the supported subset, each emitted as a
podman runflag with no change to the single-pod model.entrypoint— list=exec, string=shell (/bin/sh -c, mirroringcommand); emitted as--entrypoint <first-token>with the remaining tokens prepended to the command position (no JSON). A string entrypoint follows Docker in ignoring the servicecommand(with avalidate()warning); the--commandoverride still applies.user/working_dir→--user/--workdirgroup_add→ repeated--group-addlabels→ repeated--label(list or map; null value = empty label, distinct fromenvironment's host-passthrough)Emission uses a declarative flag table (
_SCALAR_FLAGS/_LIST_FLAGS) plus a shared_key_value_pairshelper reused byenvironmentandlabels;run_flagswas refactored into focused helpers to stay under ruff's complexity gate.${VAR}interpolation and the stderr referenced-variables note cover the new fields automatically.Design and rationale (single home, not restated here):
planning/changes/2026-07-09.03-core-process-identity-service-keys.mdplanning/audits/2026-07-09-compose-spec-coverage.mdplanning/decisions/2026-07-09-reject-namespace-network-keys.mdBehavior promoted into
architecture/supported-subset.mdin the same PR.Tests: 151 passing at 100% line coverage;
just lint-ciclean.🤖 Generated with Claude Code