feat: resolve Compose-spec variable interpolation#18
Merged
Conversation
compose2pod passed environment/command values through to podman verbatim,
so a compose file using ${VAR} reached the container as the literal
placeholder text instead of the resolved value. Add interpolate.py to
resolve $VAR, ${VAR}, ${VAR:-default}, ${VAR-default}, ${VAR:?msg},
${VAR?msg}, ${VAR:+alt}, ${VAR+alt}, and $$ against the process
environment before validate/emit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
environment/other string values through topodman runverbatim; a compose file using${VAR}reached the container as the literal placeholder text instead of the resolved value (single-quoted byshlex.quote, so the shell never expanded it either)compose2pod/interpolate.py, resolving$VAR,${VAR},${VAR:-default},${VAR-default},${VAR:?msg},${VAR?msg},${VAR:+alt},${VAR+alt}, and$$against the process environment, wired in beforevalidate()/emit_script().envfile support (out of scope, documented) — only the caller's existing environment is consultedplanning/changes/2026-07-08.06-variable-interpolation.md; promoted intoarchitecture/supported-subset.mdandREADME.mdTest plan
just test-ci— 123 tests, 100% coveragejust lint-ci— ruff, ty, eof-fixer, planning check all clean${VAR}in anenvironmentvalue now resolves to the real value in the emitted-eflag instead of the literal placeholder