fix(memory): honor MEMORY_FILE_PATH relative to cwd and prepare storage dir#4327
Open
KirtiRamchandani wants to merge 1 commit into
Open
Conversation
…ge dir Resolve relative MEMORY_FILE_PATH against process.cwd() instead of the installed package directory, create parent directories for custom paths, and migrate legacy .json custom paths to .jsonl. Fixes modelcontextprotocol#692
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
MEMORY_FILE_PATHwas resolved relative to the installed package directory when a relative path was provided, so MCP clients configuring a workspace-local path still wrote into the npx cache directory (#692).Custom absolute paths also failed when parent directories did not exist yet.
Root cause
import.meta.urlinstead ofprocess.cwd().jsonpaths were not migrated to JSONL like the default pathFix
MEMORY_FILE_PATHwithpath.resolve(process.cwd(), ...)mkdirparent directories for custom storage pathsmemory.jsontomemory.jsonlFixes #692