fix(filesystem): respect CLI directories when client supports MCP roots#3938
Open
ssam18 wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
fix(filesystem): respect CLI directories when client supports MCP roots#3938ssam18 wants to merge 1 commit intomodelcontextprotocol:mainfrom
ssam18 wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
cliffhall
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a client advertises roots support, the server was unconditionally replacing CLI-provided directories with whatever the client returned, making it impossible to scope the server to a directory outside the project root.
The fix tracks whether directories were passed via CLI args at startup and skips the roots fetch in both the
oninitializedhandler and theroots/list_changednotification handler when they were. MCP roots now only kick in as a fallback when no CLI args are given. Fixes #3929