-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Send application_type during Dynamic Client Registration (SEP-837)
#2930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -67,6 +67,9 @@ | |
| # servers may also return additional types they support | ||
| response_types: list[str] = ["code"] | ||
| scope: str | None = None | ||
| # SEP-837: OIDC application_type. Defaults to "native" since MCP clients typically use | ||
| # loopback redirect URIs; set "web" for remote browser-based clients on a non-local host. | ||
| application_type: Literal["web", "native"] = "native" | ||
|
Check failure on line 72 in src/mcp/shared/auth.py
|
||
|
Comment on lines
+70
to
+72
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔴 The new Extended reasoning...What the bug isThis PR adds Code path / step-by-step proof
Why nothing prevents it and what the impact isBefore this PR the key simply wasn't modeled: an inbound How to fixAdd one line to the passthrough block in application_type=client_metadata.application_type,so the stored and echoed |
||
|
|
||
| # these fields are currently unused, but we support & store them for potential | ||
| # future use | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.