Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -999,12 +999,9 @@ private McpRequestHandler<McpSchema.CompleteResult> completionCompleteRequestHan
.message("Prompt not found: " + promptReference.name())
.build());
}
if (!promptSpec.prompt()
.arguments()
.stream()
.filter(arg -> arg.name().equals(argumentName))
.findFirst()
.isPresent()) {
List<McpSchema.PromptArgument> arguments = promptSpec.prompt().arguments();
if (arguments == null
|| !arguments.stream().filter(arg -> arg.name().equals(argumentName)).findFirst().isPresent()) {

logger.warn("Argument not found: {} in prompt: {}", argumentName, promptReference.name());

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -744,12 +744,9 @@ private McpStatelessRequestHandler<McpSchema.CompleteResult> completionCompleteR
.message("Prompt not found: " + promptReference.name())
.build());
}
if (!promptSpec.prompt()
.arguments()
.stream()
.filter(arg -> arg.name().equals(argumentName))
.findFirst()
.isPresent()) {
List<McpSchema.PromptArgument> arguments = promptSpec.prompt().arguments();
if (arguments == null
|| !arguments.stream().filter(arg -> arg.name().equals(argumentName)).findFirst().isPresent()) {

logger.warn("Argument not found: {} in prompt: {}", argumentName, promptReference.name());

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -184,10 +184,10 @@ void testCompletionShouldReturnExpectedSuggestions(String clientType) {
true // hasMore
));

AtomicReference<CompleteRequest> samplingRequest = new AtomicReference<>();
AtomicReference<CompleteRequest> completeRequest = new AtomicReference<>();
BiFunction<McpTransportContext, CompleteRequest, CompleteResult> completionHandler = (transportContext,
request) -> {
samplingRequest.set(request);
completeRequest.set(request);
return completionResponse;
};

Expand All @@ -214,9 +214,9 @@ void testCompletionShouldReturnExpectedSuggestions(String clientType) {

assertThat(result).isNotNull();

assertThat(samplingRequest.get().argument().name()).isEqualTo("language");
assertThat(samplingRequest.get().argument().value()).isEqualTo("py");
assertThat(samplingRequest.get().ref().type()).isEqualTo(PromptReference.TYPE);
assertThat(completeRequest.get().argument().name()).isEqualTo("language");
assertThat(completeRequest.get().argument().value()).isEqualTo("py");
assertThat(completeRequest.get().ref().type()).isEqualTo(PromptReference.TYPE);
}
finally {
mcpServer.close();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,9 @@
import org.apache.catalina.LifecycleState;
import org.apache.catalina.startup.Tomcat;

import static org.assertj.core.api.Assertions.assertThat;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import static org.assertj.core.api.Assertions.assertThatExceptionOfType;

import io.modelcontextprotocol.client.McpClient;
import io.modelcontextprotocol.client.transport.HttpClientSseClientTransport;
Expand All @@ -37,6 +35,9 @@
import io.modelcontextprotocol.spec.McpSchema.ServerCapabilities;
import io.modelcontextprotocol.spec.McpError;

import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatExceptionOfType;

/**
* Tests for completion functionality with context support.
*
Expand Down Expand Up @@ -324,4 +325,35 @@ void testCompletionErrorOnMissingContext() {
mcpServer.close();
}

@Test
void testPromptWithoutArgumentsCompletionForArgument() {
BiFunction<McpSyncServerExchange, CompleteRequest, CompleteResult> completionHandler = (exchange,
request) -> new CompleteResult(new CompleteResult.CompleteCompletion(List.of("test"), 1, false));

McpSchema.Prompt prompt = new Prompt("test-prompt", "this is a test prompt", null);

var mcpServer = McpServer.sync(mcpServerTransportProvider)
.capabilities(ServerCapabilities.builder().completions().build())
.prompts(new McpServerFeatures.SyncPromptSpecification(prompt,
(mcpSyncServerExchange, getPromptRequest) -> null))
.completions(new McpServerFeatures.SyncCompletionSpecification(
new PromptReference(PromptReference.TYPE, "test-prompt"), completionHandler))
.build();

try (var mcpClient = clientBuilder.clientInfo(new McpSchema.Implementation("Sample " + "client", "0.0.0"))
.build()) {
InitializeResult initResult = mcpClient.initialize();
assertThat(initResult).isNotNull();

// try completing an argument knowing that the prompt is not parameterized
CompleteRequest request = new CompleteRequest(new PromptReference(PromptReference.TYPE, "test-prompt"),
new CompleteRequest.CompleteArgument("arg", "val"));

CompleteResult completeResult = mcpClient.completeCompletion(request);
assertThat(completeResult.completion().values()).isEmpty();
}

mcpServer.close();
}

}
Loading