-
Notifications
You must be signed in to change notification settings - Fork 438
mcp: Allow registration of custom JSON-RPC methods #956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
370304a
c4b8630
7edd01c
51f3a2b
e5748ee
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,105 @@ | ||
| // Copyright 2025 The Go MCP SDK Authors. All rights reserved. | ||
| // Use of this source code is governed by the license | ||
| // that can be found in the LICENSE file. | ||
|
|
||
| // The custom-method example demonstrates registering and calling a custom | ||
| // JSON-RPC method that is not part of the standard MCP spec. | ||
| // | ||
| // The server registers a "latin/translate" method that translates simple | ||
| // English phrases into Latin. A client connects over an in-memory transport, | ||
| // calls the custom method, and prints the result. | ||
| package main | ||
|
|
||
| import ( | ||
| "context" | ||
| "fmt" | ||
| "log" | ||
| "strings" | ||
|
|
||
| "github.com/modelcontextprotocol/go-sdk/mcp" | ||
| ) | ||
|
|
||
| type TranslateParams struct { | ||
| mcp.ParamsBase | ||
| Text string `json:"text"` | ||
| } | ||
|
|
||
| type TranslateResult struct { | ||
| mcp.ResultBase | ||
| Latin string `json:"latin"` | ||
| } | ||
|
|
||
| var translations = map[string]string{ | ||
| "hello": "salve", | ||
| "goodbye": "vale", | ||
| "thank you": "gratias tibi ago", | ||
| "how are you": "quid agis", | ||
| "good morning": "bonum mane", | ||
| "good night": "bonam noctem", | ||
| "friend": "amicus", | ||
| "water": "aqua", | ||
| "love": "amor", | ||
| "war": "bellum", | ||
| "peace": "pax", | ||
| "truth": "veritas", | ||
| "light": "lux", | ||
| "time": "tempus", | ||
| "life": "vita", | ||
| "death": "mors", | ||
| "star": "stella", | ||
| "earth": "terra", | ||
| "sea": "mare", | ||
| "the die is cast": "alea iacta est", | ||
| "i came i saw i conquered": "veni vidi vici", | ||
| "seize the day": "carpe diem", | ||
| } | ||
|
|
||
| func main() { | ||
| ctx := context.Background() | ||
|
|
||
| server := mcp.NewServer(&mcp.Implementation{Name: "latin-server", Version: "v1.0.0"}, nil) | ||
|
|
||
| mcp.AddReceivingCustomMethod(server, "latin/translate", | ||
| func(ctx context.Context, ss *mcp.ServerSession, params *TranslateParams) (*TranslateResult, error) { | ||
| key := strings.ToLower(strings.TrimSpace(params.Text)) | ||
| latin, ok := translations[key] | ||
| if !ok { | ||
| latin = fmt.Sprintf("[unknown: %q — try: %s]", params.Text, knownPhrases()) | ||
| } | ||
| return &TranslateResult{Latin: latin}, nil | ||
| }) | ||
|
|
||
| ct, st := mcp.NewInMemoryTransports() | ||
|
|
||
| ss, err := server.Connect(ctx, st, nil) | ||
| if err != nil { | ||
| log.Fatal(err) | ||
| } | ||
| defer ss.Close() | ||
|
|
||
| client := mcp.NewClient(&mcp.Implementation{Name: "latin-client", Version: "v1.0.0"}, nil) | ||
| translate := mcp.AddSendingCustomMethod[*TranslateParams, *TranslateResult](client, "latin/translate") | ||
|
|
||
| cs, err := client.Connect(ctx, ct, nil) | ||
| if err != nil { | ||
| log.Fatal(err) | ||
| } | ||
| defer cs.Close() | ||
|
|
||
| phrases := []string{"Hello", "Seize the day", "Peace", "Truth", "I came I saw I conquered"} | ||
| for _, phrase := range phrases { | ||
| result, err := translate(ctx, cs, &TranslateParams{Text: phrase}) | ||
| if err != nil { | ||
| log.Fatalf("translate %q: %v", phrase, err) | ||
| } | ||
| fmt.Printf("%-35s → %s\n", phrase, result.Latin) | ||
| } | ||
| } | ||
|
|
||
| func knownPhrases() string { | ||
| phrases := make([]string, 0, len(translations)) | ||
| for k := range translations { | ||
| phrases = append(phrases, fmt.Sprintf("%q", k)) | ||
| } | ||
| return strings.Join(phrases, ", ") | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,6 +10,8 @@ import ( | |
| "fmt" | ||
| "iter" | ||
| "log/slog" | ||
| "maps" | ||
| "reflect" | ||
| "slices" | ||
| "strings" | ||
| "sync" | ||
|
|
@@ -32,6 +34,7 @@ type Client struct { | |
| sessions []*ClientSession | ||
| sendingMethodHandler_ MethodHandler | ||
| receivingMethodHandler_ MethodHandler | ||
| customSendMethods map[string]methodInfo | ||
| } | ||
|
|
||
| // NewClient creates a new [Client]. | ||
|
|
@@ -64,6 +67,7 @@ func NewClient(impl *Implementation, options *ClientOptions) *Client { | |
| roots: newFeatureSet(func(r *Root) string { return r.URI }), | ||
| sendingMethodHandler_: defaultSendingMethodHandler, | ||
| receivingMethodHandler_: defaultReceivingMethodHandler[*ClientSession], | ||
| customSendMethods: make(map[string]methodInfo), | ||
| } | ||
| } | ||
|
|
||
|
|
@@ -945,7 +949,13 @@ var clientMethodInfos = map[string]methodInfo{ | |
| } | ||
|
|
||
| func (cs *ClientSession) sendingMethodInfos() map[string]methodInfo { | ||
| return serverMethodInfos | ||
| if len(cs.client.customSendMethods) == 0 { | ||
| return serverMethodInfos | ||
| } | ||
| infos := make(map[string]methodInfo, len(serverMethodInfos)+len(cs.client.customSendMethods)) | ||
| maps.Copy(infos, serverMethodInfos) | ||
| maps.Copy(infos, cs.client.customSendMethods) | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we should probably disallow to override the standard methods |
||
| return infos | ||
| } | ||
|
|
||
| func (cs *ClientSession) receivingMethodInfos() map[string]methodInfo { | ||
|
|
@@ -1218,3 +1228,33 @@ func paginate[P listParams, R listResult[T], T any](ctx context.Context, params | |
| } | ||
| } | ||
| } | ||
|
|
||
| // AddSendingCustomMethod registers a custom method that the client can send | ||
| // to the server and returns a typed caller function. | ||
| // | ||
| // The returned function calls the custom method through the client's sending | ||
| // middleware chain, with full type safety on both params and result. | ||
| // | ||
| // callSearch := mcp.AddSendingCustomMethod[*SearchParams, *SearchResult](c, "acme/search") | ||
| // result, err := callSearch(ctx, cs, &SearchParams{Query: "hello"}) | ||
| func AddSendingCustomMethod[P paramsPtr[PT], R Result, PT any]( | ||
| c *Client, | ||
| method string, | ||
| ) func(ctx context.Context, cs *ClientSession, params P) (R, error) { | ||
| mi := methodInfo{ | ||
| newResult: func() Result { | ||
| return reflect.New(reflect.TypeFor[R]().Elem()).Interface().(R) | ||
| }, | ||
| } | ||
|
|
||
| c.mu.Lock() | ||
| defer c.mu.Unlock() | ||
| c.customSendMethods[method] = mi | ||
|
|
||
| return func(ctx context.Context, cs *ClientSession, params P) (R, error) { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not sure exposing this via a return value will cover all the use cases. Most of the users of this will probably be extensions, which will do the registration for the developer. Not sure how easy it will be to propagate this. |
||
| return handleSend[R](ctx, method, &ClientRequest[P]{ | ||
| Session: cs, | ||
| Params: params, | ||
| }) | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -52,6 +52,7 @@ type Server struct { | |
| sessions []*ServerSession | ||
| sendingMethodHandler_ MethodHandler | ||
| receivingMethodHandler_ MethodHandler | ||
| customMethods map[string]methodInfo | ||
| resourceSubscriptions map[string]map[*ServerSession]bool // uri -> session -> bool | ||
| pendingNotifications map[string]*time.Timer // notification name -> timer for pending notification send | ||
| } | ||
|
|
@@ -195,6 +196,7 @@ func NewServer(impl *Implementation, options *ServerOptions) *Server { | |
| receivingMethodHandler_: defaultReceivingMethodHandler[*ServerSession], | ||
| resourceSubscriptions: make(map[string]map[*ServerSession]bool), | ||
| pendingNotifications: make(map[string]*time.Timer), | ||
| customMethods: make(map[string]methodInfo), | ||
| } | ||
| } | ||
|
|
||
|
|
@@ -1422,7 +1424,19 @@ func initializeMethodInfo() methodInfo { | |
|
|
||
| func (ss *ServerSession) sendingMethodInfos() map[string]methodInfo { return clientMethodInfos } | ||
|
|
||
| func (ss *ServerSession) receivingMethodInfos() map[string]methodInfo { return serverMethodInfos } | ||
| func (s *Server) receivingMethodInfos() map[string]methodInfo { | ||
| if len(s.customMethods) == 0 { | ||
| return serverMethodInfos | ||
| } | ||
| infos := make(map[string]methodInfo, len(serverMethodInfos)+len(s.customMethods)) | ||
| maps.Copy(infos, serverMethodInfos) | ||
| maps.Copy(infos, s.customMethods) | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. unprotected access (s.mu) |
||
| return infos | ||
| } | ||
|
|
||
| func (ss *ServerSession) receivingMethodInfos() map[string]methodInfo { | ||
| return ss.server.receivingMethodInfos() | ||
| } | ||
|
|
||
| func (ss *ServerSession) sendingMethodHandler() MethodHandler { | ||
| s := ss.server | ||
|
|
@@ -1630,3 +1644,44 @@ func paginateList[P listParams, R listResult[T], T any](fs *featureSet[T], pageS | |
| *res.nextCursorPtr() = nextCursor | ||
| return res, nil | ||
| } | ||
|
|
||
| // AddReceivingCustomMethod registers a handler for a custom (non-standard) | ||
| // JSON-RPC method on the server. | ||
| // | ||
| // When a client sends a request with the given method name, the params will be | ||
| // unmarshaled into P, the handler will be called, and the returned R will be | ||
| // marshaled as the JSON-RPC result. | ||
| // | ||
| // Custom methods go through the server's middleware chain just like standard | ||
| // MCP methods (tools/call, prompts/list, etc.). | ||
| // | ||
| // P and R must implement [Params] and [Result] respectively, which is most | ||
| // easily done by embedding [ParamsBase] and [ResultBase]: | ||
| // | ||
| // type SearchParams struct { | ||
| // mcp.ParamsBase | ||
| // Query string `json:"query"` | ||
| // } | ||
| // | ||
| // type SearchResult struct { | ||
| // mcp.ResultBase | ||
| // Hits []string `json:"hits"` | ||
| // } | ||
| // | ||
| // mcp.AddReceivingCustomMethod(server, "acme/search", | ||
| // func(ctx context.Context, ss *mcp.ServerSession, params *SearchParams) (*SearchResult, error) { | ||
| // return &SearchResult{Hits: []string{"result"}}, nil | ||
| // }) | ||
| func AddReceivingCustomMethod[P paramsPtr[T], R Result, T any]( | ||
| s *Server, | ||
| method string, | ||
| handler func(ctx context.Context, ss *ServerSession, params P) (R, error), | ||
| ) { | ||
| typed := typedServerMethodHandler[P, R](func(ctx context.Context, req *ServerRequest[P]) (R, error) { | ||
| return handler(ctx, req.Session, req.Params) | ||
| }) | ||
|
|
||
| s.mu.Lock() | ||
| defer s.mu.Unlock() | ||
| s.customMethods[method] = newServerMethodInfo(typed, missingParamsOK) | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It feels a bit unnecessary to construct the map on every call. Maybe it's worth moving the source of truth map containing all methods under an appropriate type (
Client?).