Skip to content

Make codegen_span stable#2882

Merged
celinval merged 3 commits into
model-checking:mainfrom
ouz-a:stable_codegen_span
Nov 29, 2023
Merged

Make codegen_span stable#2882
celinval merged 3 commits into
model-checking:mainfrom
ouz-a:stable_codegen_span

Conversation

@ouz-a

@ouz-a ouz-a commented Nov 16, 2023

Copy link
Copy Markdown
Contributor

Follow up pr to #2871 as stable_mir::ty::Span have ability to get_filename and get_lineinfo we could start adopting it.

@ouz-a
ouz-a requested a review from a team as a code owner November 16, 2023 19:33
@github-actions github-actions Bot added the Z-EndToEndBenchCI Tag a PR to run benchmark CI label Nov 16, 2023
@celinval
celinval enabled auto-merge (squash) November 17, 2023 15:36
@celinval

celinval commented Nov 20, 2023

Copy link
Copy Markdown
Contributor

@ouz-a, I believe you need to initialize the StableMIR components. In this case, I suggest that you move the initial initialization to be inside compiler_interface::codegen_crate(). That case, the entire codegen step can be used with the same SMIR session.

Note that you will have to remove the initialization inside analysis. Thanks!

@ouz-a

ouz-a commented Nov 27, 2023

Copy link
Copy Markdown
Contributor Author

Update: We are waiting for Opaque fix in this rust-lang/rust#118172 pr to land, before continuing the work on this as this is currently blocked by how we store strings.

auto-merge was automatically disabled November 29, 2023 08:29

Head branch was pushed to by a user without write access

@ouz-a
ouz-a force-pushed the stable_codegen_span branch from 00ac3cb to 042615e Compare November 29, 2023 08:29
@celinval
celinval enabled auto-merge (squash) November 29, 2023 18:34
@celinval
celinval merged commit 9d01f97 into model-checking:main Nov 29, 2023
@ouz-a ouz-a mentioned this pull request Dec 2, 2023
Merged
celinval pushed a commit that referenced this pull request Dec 8, 2023
@ouz-a
Stabilize find_debug_info (#2912)
01bf411 
Last time we stabilized
#2882, this continues the
trend and stabilizes `find_debug_info` as well.
@feliperodri feliperodri mentioned this pull request Dec 13, 2023
Merged
@celinval celinval mentioned this pull request Jan 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@celinval celinval celinval approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@ouz-a ouz-a

Labels

Z-EndToEndBenchCI Tag a PR to run benchmark CI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ouz-a @celinval