Repository navigation
Conversation
LastCap fails in root filesystems without /proc/sys/kernel/cap_last_cap. Probe PR_CAPBSET_READ on the running kernel when the procfs file is missing, and stop at the first unsupported capability. Add a regression test that compares this fallback with the procfs result. Fixes: moby#265 Signed-off-by: Eduard Zateev <hackerowskiy@gmail.com>
Collaborator
|
I am going to solve this differently. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LastCapreads/proc/sys/kernel/cap_last_capand returns an error if the file is absent. This makes capability operations fail in root filesystems without a proc mount.When the procfs file is missing, probe
PR_CAPBSET_READuntil the kernel reports an unsupported capability. Keep the procfs path when it is available, and add a regression test for the fallback.Tested on Fedora 44 ARM64:
cd capability && go test ./...Fixes #265.