Skip to content

devices: skip .incus-mounts when listing devices #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SashaMIT wants to merge 1 commit into
base: main
Choose a base branch
from
Open

devices: skip .incus-mounts when listing devices #261

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion devices/device_unix.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,8 @@ func GetDevices(path string) ([]*config.Device, error) {
switch f.Name() {
// ".lxc" & ".lxd-mounts" added to address https://github.com/lxc/lxd/issues/2825
// ".udev" added to address https://github.com/opencontainers/runc/issues/2093
case "pts", "shm", "fd", "mqueue", ".lxc", ".lxd-mounts", ".udev":
// ".incus-mounts" added to address https://github.com/moby/sys/issues/260
case "pts", "shm", "fd", "mqueue", ".lxc", ".lxd-mounts", ".udev", ".incus-mounts":
continue
Comment on lines 101 to 105

@thaJeztah thaJeztah Oct 19, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker, but we could wrap these, so that the comments can be directly together with the option(s);

			case "pts", "shm", "fd", "mqueue",
				".incus-mounts",       // added to address https://github.com/moby/sys/issues/260
				".lxc", ".lxd-mounts", // added to address https://github.com/lxc/lxd/issues/2825
				".udev": // added to address https://github.com/opencontainers/runc/issues/2093
				continue

default:
sub, err := GetDevices(filepath.Join(path, f.Name()))
Expand Down
Loading