Repository navigation
test: fix network namespace setup and cleanup - #50
Merged
Merged
Conversation
Remove the dependency on the legacy ns package, which initializes additional netlink handles and attempts to load kernel modules that are not needed by the IPVS tests. It also logs initialization errors instead of returning them to the caller. Manage the test network namespace directly instead: - Restore the original namespace during teardown. - Balance OS thread locking and unlocking. - Handle namespace setup and restoration errors. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
There was a problem hiding this comment.
🟢 Approval recommended
The namespace and OS-thread lifecycle is correctly handled across setup, teardown, and failure paths.
0 open findings
What changed in this PR
Reworks Linux test namespace management to avoid the legacy ns package and reliably restore thread state.
Changes:
- Captures and restores the original network namespace.
- Balances OS-thread locking across success and failure paths.
- Reports namespace setup and restoration failures.
| File | Description |
|---|---|
ipvs_linux_test.go |
Implements direct, error-aware test namespace lifecycle management. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
vvoland
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the dependency on the legacy ns package, which initializes additional netlink handles and attempts to load kernel modules that are not needed by the IPVS tests. It also logs initialization errors instead of returning them to the caller.
Manage the test network namespace directly instead: