Skip to content

Doc: add guidance on taking over a stale pull request#13877

Open
Aniketsy wants to merge 7 commits into
mne-tools:mainfrom
Aniketsy:fix-13860
Open

Doc: add guidance on taking over a stale pull request#13877
Aniketsy wants to merge 7 commits into
mne-tools:mainfrom
Aniketsy:fix-13860

Conversation

@Aniketsy
Copy link
Copy Markdown
Contributor

Fixes #13860

Screenshot 2026-04-29 124513

What does this implement/fix?

Additional information

@Aniketsy
Copy link
Copy Markdown
Contributor Author

I think we don't need changelog entry for this, please let me know if this needs further improvements. (i'll fix these ci failures)
thanks!

Copy link
Copy Markdown
Contributor

@tsbinns tsbinns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Aniketsy, thanks for the PR.
Have got some small comments below, with some bigger things that @drammock can hopefully weigh in on.

Comment thread doc/development/contributing.rst Outdated
Comment thread doc/development/contributing.rst Outdated
Comment thread doc/development/contributing.rst Outdated
Comment thread doc/development/contributing.rst Outdated
Comment thread doc/development/contributing.rst Outdated
Comment thread doc/development/contributing.rst Outdated
Aniketsy and others added 2 commits April 30, 2026 00:39
Co-authored-by: Thomas S. Binns <t.s.binns@outlook.com>
Co-authored-by: Thomas S. Binns <t.s.binns@outlook.com>
@Aniketsy
Copy link
Copy Markdown
Contributor Author

@tsbinns thanks ❤️ for the review and the pointer, it make sense, to add some more details, i'll address these review points tomorrow, as its here approx 1 am ...

@tsbinns
Copy link
Copy Markdown
Contributor

tsbinns commented May 23, 2026

Hi @Aniketsy. The outstanding questions have now been resolved. Do you want to address the remaining points? If it helps, I can also push some commits.

@Aniketsy
Copy link
Copy Markdown
Contributor Author

Hi @Aniketsy. The outstanding questions have now been resolved. Do you want to address the remaining points? If it helps, I can also push some commits.

I've pushed some changes, please feel free to push some commits or I can also address these ci fails and review points, but i may take some time. Thanks!

@tsbinns
Copy link
Copy Markdown
Contributor

tsbinns commented May 26, 2026

Just pushed some changes. Let's also see if the errors are resolved.

Comment thread doc/development/contributing.rst Outdated
Comment thread doc/development/contributing.rst Outdated
Co-authored-by: Daniel McCloy <dan@mccloy.info>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

guidance on how to take over someone else's stale PR

3 participants