Repository navigation
fix(playground): TypeScript runs, timers are awaited, Console text is plain - #205
Merged
Merged
Conversation
… plain - TypeScript: types are stripped by Monaco's own TypeScript worker (no new dependency) and step and error lines are mapped back to the learner's source through the emit's source map - a run reports once no timer is pending, or at the execution timeout with a note in the Console, instead of 50 ms after the synchronous code - Console text is no longer HTML-escaped before React escapes it, and a string prints as written - the toolbar fits from 768px up; Run is always visible - "example snippet" becomes "example"; "timeline" wording becomes steps Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 6 of the ADR 0004 build plan: the basics the October audit found broken.
Changes
services/sourceMapLines.ts). A syntax error shows in the Console with its line.components/execution/sandboxRuntime.ts) tracks pending timers and reports when none is left, instead of 50 ms after the synchronous code. An interval that is never cleared ends at the execution timeout with a note in the Console.escapeHtmlandsanitizeForDisplayare gone; a string prints as written.utils/examples.ts); user-visible "timeline" wording is now about steps. The old step and lens types keep their names because the lens PR replaces them.PlaygroundApp.tsxthat could leave a TypeScript run stuck on "running".Evidence
/playground, 1024px wide: the default code prints all five lines including the one after a 1 s timer; strings show without entities or quotes; the TypeScript Promise Chain example runs and records 7 steps; Run is visible.Open
🤖 Generated with Claude Code