Openfx filters#1271
Merged
Merged
Conversation
Some plugins are registered twice in the library. This change will not bother to create a filter service if it already exists. Affected openfx plugins: net.sf.openfx.HueCorrect net.sf.openfx.MergePlugin net.sf.openfx.MergePlus net.sf.openfx.MergeMatte net.sf.openfx.MergeMultiply net.sf.openfx.MergeIn net.sf.openfx.MergeOut net.sf.openfx.MergeScreen net.sf.openfx.MergeMax net.sf.openfx.MergeMin net.sf.openfx.MergeDifference net.sf.openfx.MergeRoto net.sf.openfx.Reformat net.sf.openfx.ShufflePlugin net.fxarena.openfx.Text fr.inria.openfx.OIIOResize net.sf.cimg.CImgBlur net.sf.cimg.CImgLaplacian net.sf.cimg.CImgChromaBlur net.sf.cimg.CImgBloom
Only used for diagnostics, currently
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves OpenFX plugin discovery in the openfx module by adding optional diagnostics during repository initialization and by avoiding registering duplicate OpenFX filters (same derived MLT service key).
Changes:
- Add compile-time toggles to enable OpenFX discovery diagnostics and optionally filter logs by plugin identifier substring.
- Add detailed diagnostic logging around plugin detection decisions (load/describe/context/pixel-depth/clip info).
- Skip registering OpenFX filters when the derived service key already exists.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
src/modules/openfx/mlt_openfx.h |
Adds diagnostic toggles and a helper to gate discovery logs. |
src/modules/openfx/mlt_openfx.c |
Adds diagnostic logging helpers and logs acceptance/rejection reasons during plugin detection. |
src/modules/openfx/factory.c |
Skips duplicate service keys and emits discovery/registration diagnostics during bundle scanning. |
Memory leak, use after free, allocation failure check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does not change the number of openfx filters that are available. It just skips registering a filter if it is a duplicate. It also adds some diagnostics that are useful when debugging plugin detection and capabilities.