fix(marketplace): pin toastr with SRI in index template (CWE-830) - #989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the recurring CodeQL "Inclusion of functionality from an untrusted source"
(CWE-830) alert on the generated marketplace
index.html.The landing-page template loaded toastr from cdnjs at
/latest/with no integritycheck, so a compromised/spoofed CDN response could inject arbitrary code into the
Function Hub page.
Change: pin toastr to 2.1.4 and add subresource integrity + crossorigin on both the
JS and CSS tags. The other CDN resources (jQuery, bootstrap, highlight.js, etc.)
are already SRI-protected.
Once merged, the existing force-rebuild CI regenerates the marketplace pages and the
open alert is cleared.