Update Item and EvolutionDetail to add new API changes - #49
Merged
Merged
Conversation
Owner
|
Hey @jemarq04 ! Thanks for another contribution ! |
Contributor
Author
|
Sounds good! |
jemarq04
changed the title
Item to add new pricing/currency changesItem and EvolutionDetail to add new API changes
Contributor
Author
|
Updated the PR to match some more breaking changes from the API on evolutions. All queries on evolutions/items work when testing with this branch. |
Owner
|
Hey @jemarq04, Thanks for another great addition to the crate ! Apologies for the delay |
Contributor
Author
|
No worries, thanks! I’m on the PokeAPI team now so it’s easy to translate any schema changes to the wrapper. Happy to help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
Itemstruct and addsCurrencyandItemPricestructs to match changes from PR PokeAPI/pokeapi#1431.To the
Itemstruct, removes thecostfield and replaces it with apricesfield. Because of the changes to the API, all queries for items have been failing as thecostfield is no longer available.Edit: Some more breaking changes were introduced with the API regarding evolution information (see PokeAPI/pokeapi#1656), so I added the changes here as well.