Skip to content

Support EvalContext changes#124

Merged
superdosh merged 4 commits intomainfrom
support-ctx-changes
Apr 28, 2026
Merged

Support EvalContext changes#124
superdosh merged 4 commits intomainfrom
support-ctx-changes

Conversation

@superdosh
Copy link
Copy Markdown
Contributor

@superdosh superdosh commented Apr 27, 2026

NodeOutput can now optionally include an updated context. When present, we make sure all parents have the same updated context, and then run the node with that updated context.

  • Also had to do some refactoring to avoid circular imports. (NodeOutput -> context.py, rename output.py to verdict.py)
  • Key change is around line 180 in dag.py
  • Updated tests
  • Fixes needed for bijection decoder #122

@superdosh superdosh requested a review from a team as a code owner April 27, 2026 19:37
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 27, 2026

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@superdosh superdosh requested review from bkorycki and bollacker April 27, 2026 19:37
Comment thread src/modelplane/evaluator/context.py
Copy link
Copy Markdown
Contributor

@bkorycki bkorycki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I'm wondering if it makes sense to somehow preserve the original context that a node used? For analysis purposes e.g. looking at the outputs from a node should show the context that was actually used at that node's computation time. Otherwise things can be misleading when we look back at the dag run.

@superdosh
Copy link
Copy Markdown
Contributor Author

This looks good. I'm wondering if it makes sense to somehow preserve the original context that a node used? For analysis purposes e.g. looking at the outputs from a node should show the context that was actually used at that node's computation time. Otherwise things can be misleading when we look back at the dag run.

This is a good idea. In theory, it should be reconstructible from what's already implemented (since we know the parents of a particular node, we can look up the parents update_ctx, though this is convoluted), so will merge this, but will try to add this shortly more explicitly in a follow up! @bkorycki

@superdosh superdosh merged commit 4db3ff0 into main Apr 28, 2026
4 checks passed
@superdosh superdosh deleted the support-ctx-changes branch April 28, 2026 20:22
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants