Repository navigation
fix(core): keep the active slide when the window resizes in large steps - #15
Merged
Merged
Conversation
Browsers clamp the scroll offset when the viewport shrinks, and Firefox later scrolls back to the slide it was clamped to. The tracker now ignores the scroll position until the resize observer has seen the new width, then pins the active slide in the centre, undoing scrolls the browser starts, until the resize is quiet or the user interacts.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resizing the window in a large step, such as from a phone width to a desktop width, could leave the carousel on another slide or between two. Browsers scroll on their own when the viewport resizes: they clamp the offset when it shrinks, and Firefox later scrolls back, smoothly, to the slide it was clamped to. The earlier resize fix only handled small steps.
Changes