fix(conversations): dedupe deferred-responses block in run_async - #496
Merged
Conversation
The Speakeasy regen in #484 re-emitted the deferred-response handling block on top of the existing one inside the sdk-class-body custom region, leaving two identical copies in run_async. The second copy unconditionally reset pending_tool_confirmations to None, silently dropping the server-side HITL confirmations computed by the first. Removes the duplicate block so HITL confirmations are preserved.
Contributor
|
Cool! You told me earlier IRL about another line that was also duplicated. I don't see it in this PR. Is it fixed already? |
tchardonnens
approved these changes
Apr 21, 2026
Contributor
Author
|
yes, by a previous regeneration |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Conversations.run_asyncinsrc/mistralai/client/conversations.py. The Speakeasy regen in chore: 🐝 Update SDK - Generate MISTRALAI MISTRALAI-SDK 2.3.2 #484 re-emitted the block (originally hand-added inside thesdk-class-bodycustom region in feat: add Human in the loop confirmations #482) on top of the existing one, leaving two identical copies.pending_tool_confirmations = None, silently dropping the server-side HITL confirmations the first block had just computed. Deleting the duplicate restores correct behavior.Notes
nonlocal pending_tool_confirmationspreviously reported inrun_stream_asyncis no longer present onmainand did not need a fix here.