clean: add same args in custom code execute_workflow_and_wait than in generated execute_workflow - #495
Merged
anth2o merged 1 commit intoApr 21, 2026
Conversation
… generated execute_workflow
anth2o
marked this pull request as ready for review
April 21, 2026 12:18
paulcacheux
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hand-written
execute_workflow_and_wait/execute_workflow_and_wait_asyncmethods were missing several parameters that the generatedexecute_workflow/execute_workflow_asyncaccept (encoded_input,task_queue,retries,server_url,timeout_ms,http_headers).This aligns both signatures so callers don't lose access to those options when using the convenience wrapper. Also fixes the
inputtype annotation to match (Anyinstead ofDict[str, Any] | BaseModel).