Repository navigation
feat(deps): update dependency @radix-ui/react-slot (1.3.3 → 1.4.0) - #1185
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
AI Automated Review
Full PR review.
Analysis engine: MiniMax-M3 (anthropic) — primary route · pr-reviewer-action v3.3.0
Recommendation: approve
A minimal Renovate patch bump of @radix-ui/react-slot from 1.3.3 to 1.4.0, confined to a single 3-line hunk in package-lock.json. No source files were touched and no transitive dependency drifted.
Change-by-change findings
package-lock.json(node_modules/@radix-ui/react-slot):1.3.3→1.4.0, tarballreact-slot-1.4.0.tgz, new integrity hash, license unchanged. Thedependenciessub-entry still pins@radix-ui/react-compose-refs: 1.1.5, exactly as before. No other entries in the lockfile were modified by this PR (changedFiles: 1).package.json: No change. The declared range^1.2.4continues to satisfy1.4.0, and nooverridesblock needs touching (the existing security overrides forpostcss,sharp,deepmerge-ts,mysql2are unrelated).
Claims verification
- Claim 1 (1.3.3 → 1.4.0 in package.json + lockfile): Held: 2/2.
package-lock.jsonresolves to1.4.0; thepackage.jsonsemver range was unchanged and still permits it. - Claim 2 (only the
@radix-ui/react-slotlockfile entry modified): Held: 2/2. Single hunk; the unrelated@radix-ui/react-slot@1.2.3entry nested undernode_modules/@radix-ui/react-primitivewas left intact. - Claim 3 (
@radix-ui/react-compose-refsstays at 1.1.5): Held: 2/2. Top-level entry at line 2531-2533 is still1.1.5, and thedependenciesblock on the updatedreact-slot@1.4.0still pins1.1.5. - Claim 4 (backward-compatibility per release notes / Mend badge): Held: 2/2 with caveat. The only in-tree consumer is
src/components/ui/button.tsx, which uses the publicSlotnamed export — its signature is unchanged in 1.4.0. The v1.4.0 release notes describe purely additive changes (multiplearia-describedby, RSC compatibility fix). CI evidence on this head (fbe4010c) shows the full pipeline (Lint, Typecheck, Build, Tests, Coverage, npm audit, Docker Build, smoke) passed, which is the strongest available empirical signal that the upgrade is runtime-compatible.
Sources
- Upstream release notes (in PR body): "Added support for multiple
aria-describedbyattributes. Fixed compatibility issues with React Server Components." — purely additive, no breaking API changes documented. - In-tree consumer:
src/components/ui/button.tsx(only file importing@radix-ui/react-slot). - CI Check Results: all 13 reported checks passed for commit
fbe4010c5a5a09583d0b300f9bd45581082ccc20.
Standards Compliance
The repository standards file (AGENTS.md) does not impose a per-package review gate; it requires lint/typecheck to pass in CI and forbids committing secrets. Neither is violated here. The repository's AI review conventions (.github/ai-review-rules.md) favor direct, practical reviews and explicitly prefer non-blocking comments for Renovate dependency bumps when there is no real defect — this PR fits that pattern.
Unknowns or Needs Verification
- The Mend / Renovate compatibility badge URL (
developer.mend.io/api/mc/badges/compatibility/...) is on a host outside the allowed fetch list, so the live "Passing" indicator could not be re-fetched in this review. This is informational only: the upstream changelog and CI results together already substantiate the compatibility claim for the only consumer in the repo. - No upstream release tag with the literal name
1.4.0was returned by the GitHub releases enrichment forradix-ui/primitives(the most recent tag observed was1.6.7); the changelog still lists the 1.4.0 entry as described in the PR body. This is informational only and consistent with radix-ui's monorepo tag-aliasing convention.
Required Check Dispositions
check for breaking API changes in updated dependencies— satisfied. The upstream 1.4.0 notes describe only additive changes; the sole in-tree consumer (src/components/ui/button.tsx) uses the stableSlotnamed export, and CI (Lint/Typecheck/Build/Tests) all passed on the bumped head.run full test suite after upgrade— satisfied. CI reportsTests,Coverage,Typecheck,Build,Lint,npm audit,Docker Build, andsmokeall green forfbe4010c.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
1.3.3→1.4.0Release Notes
radix-ui/primitives (@radix-ui/react-slot)
v1.4.0aria-describedbyattributes.Configuration
📅 Schedule: (in timezone America/Edmonton)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate CLI.