Repository navigation
chore(release): 1.1.0, externalize @base-ui/react as a peer dependency - #265
Merged
Merged
Conversation
lucaspunz
marked this pull request as ready for review
October 20, 2026 23:34
pqoqubbw
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@base-ui/reactfrom a pinned dependency to a^1.1.0peer dependency and mark it external in the library build, so consumers share their own copy instead of bundling a second one.Test Plan
pnpm build;distimports@base-ui/reactinstead of bundling ittsc --noEmitandpnpm lintpass against@base-ui/react1.9.0Note
Medium Risk
Packaging change can break consumers that do not install the new peer or pin an incompatible Base UI version; runtime behavior depends on the app’s
@base-ui/react(tooltips, code-group tabs/menus).Overview
@mintlify/components 1.1.0 stops shipping
@base-ui/reactinside the library bundle. It is now a peer dependency (^1.1.0), and the Vite library build treats@base-ui/reactand its subpath imports as external so the publisheddistre-exports those imports for the host app’s copy.Consumers need to install
@base-ui/reactthemselves (unless their package manager auto-installs peers). Local dev/Storybook keeps@base-ui/react1.9.0 as a devDependency; the changelog calls out the install requirement (#265).Reviewed by Cursor Bugbot for commit 89fb36a. Bugbot is set up for automated code reviews on this repo. Configure here.