Skip to content

fix(deps): move grpc back onto the patched 1.83.x line - #268

Merged
harshavardhana merged 1 commit into
minio:mainfrom
harshavardhana:fix/grpc-1832
Sep 18, 2026
Merged

harshavardhana merged 1 commit into
minio:mainfrom
harshavardhana:fix/grpc-1832

Conversation

@harshavardhana

@harshavardhana harshavardhana commented Sep 18, 2026

Copy link
Copy Markdown
Member

Summary

Moves google.golang.org/grpc from v1.84.0 back to v1.83.2. My own bump in
#266 traded one advisory for another.

Why

#266 took grpc to v1.84.0 to clear GO-2026-6348. That was more than
needed: the fix for 6348 landed in v1.83.1, and v1.83.2 additionally
carries the fix for GO-2026-6443 (server panic via missing authority or
Host headers).

GO-2026-6443's affected ranges:

introduced 0          fixed 1.82.2
introduced 1.83.0     fixed 1.83.2
introduced 1.84.0-dev fixed 1.85.0-dev.0.20260825072537-93e31b48545e

So v1.84.0 is inside the third range and its only fix is a v1.85.0-dev
pseudo-version. v1.83.2 is outside all three.

This surfaced downstream: aistor picks grpc up through this module, and with
v1.84.0 forced by MVS its Basic Checks govulncheck fails on GO-2026-6443
where edge -- still on v1.83.2 -- is clean. Lowering it here is what lets the
consumer back onto the patched line, since MVS takes the maximum.

Testing

go build ./... and go test ./... pass. govulncheck ./... reports nothing
for grpc.

Summary by CodeRabbit

  • Chores
    • Updated underlying networking and remote communication components to revised versions.

minio#266 bumped grpc to v1.84.0 for GO-2026-6348, but v1.83.1 already carried
that fix and v1.83.2 carries GO-2026-6443's as well. Going to v1.84.0 left the
patched 1.83.x line for one where GO-2026-6443 is unfixed -- its only fix is a
v1.85.0-dev pseudo-version -- so the bump traded one advisory for another.

v1.83.2 is outside the affected range of both.
@coderabbitai

coderabbitai Bot commented Sep 18, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 8b575209-fbbc-475f-8bfd-6d909f85a4f7

📥 Commits

Reviewing files that changed from the base of the PR and between b5f0782 and ce5fc16.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The Go module manifest updates two indirect dependencies: golang.org/x/net moves to v0.58.0, and google.golang.org/grpc moves to v1.83.2.

Changes

Dependency updates

Layer / File(s) Summary
Update indirect module versions
go.mod
golang.org/x/net is upgraded from v0.57.0 to v0.58.0. google.golang.org/grpc is downgraded from v1.84.0 to v1.83.2.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Suggested reviewers: dilverse

Merge Risk: ⚪ Minimal · up to ce5fc

The dependency update has no established correctness, security, or availability risk and is ready to merge.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: moving gRPC back to the patched 1.83.x dependency line.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the module trail
Two versions shift along the rail
Net hops forward, grpc steps back
The manifest keeps its track
With tidy paws, the change is done

Comment @coderabbitai help to get the list of available commands.

@harshavardhana
harshavardhana merged commit c71d48e into minio:main Sep 18, 2026
11 checks passed
@harshavardhana
harshavardhana deleted the fix/grpc-1832 branch September 18, 2026 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant