fix(deps): move grpc back onto the patched 1.83.x line - #268
Conversation
minio#266 bumped grpc to v1.84.0 for GO-2026-6348, but v1.83.1 already carried that fix and v1.83.2 carries GO-2026-6443's as well. Going to v1.84.0 left the patched 1.83.x line for one where GO-2026-6443 is unfixed -- its only fix is a v1.85.0-dev pseudo-version -- so the bump traded one advisory for another. v1.83.2 is outside the affected range of both.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe Go module manifest updates two indirect dependencies: ChangesDependency updates
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to The dependency update has no established correctness, security, or availability risk and is ready to merge. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the module trail Comment |
Summary
Moves
google.golang.org/grpcfrom v1.84.0 back to v1.83.2. My own bump in#266 traded one advisory for another.
Why
#266 took grpc to v1.84.0 to clear GO-2026-6348. That was more than
needed: the fix for 6348 landed in v1.83.1, and v1.83.2 additionally
carries the fix for GO-2026-6443 (server panic via missing authority or
Host headers).
GO-2026-6443's affected ranges:
So v1.84.0 is inside the third range and its only fix is a
v1.85.0-devpseudo-version. v1.83.2 is outside all three.
This surfaced downstream: aistor picks grpc up through this module, and with
v1.84.0 forced by MVS its
Basic Checksgovulncheck fails on GO-2026-6443where edge -- still on v1.83.2 -- is clean. Lowering it here is what lets the
consumer back onto the patched line, since MVS takes the maximum.
Testing
go build ./...andgo test ./...pass.govulncheck ./...reports nothingfor grpc.
Summary by CodeRabbit