feat(anton): Turn-Key Data Vault for cloud OAuth connectors - #400
Merged
Conversation
…mail)
Adds TurnKeyDataVault, a DataVault Protocol implementation backed by a
live call to auth's POST /v1/oauth/{engine}/token endpoint with the turn
key as bearer auth. build_cloud_chat_session() now wires it in when the
turn's new `oauth` field (forwarded by scratchpad-controller) is present,
calling the same restore_namespaced_env() desktop's harness already uses
so DS_* env vars and credential scrubbing work identically in the cloud.
Part of the 6-repo cloud OAuth connectors MVP (auth, cowork-server,
cowork, Mind-Castle, anton, scratchpad-controller).
This was referenced Aug 26, 2026
martyna-mindsdb
marked this pull request as ready for review
August 26, 2026 19:21
tino097
reviewed
Aug 27, 2026
tino097
left a comment
tino097
left a comment
Contributor
There was a problem hiding this comment.
Inline notes from a review pass on the OAuth Proxy + Data Vault change set.
…nnection name so multi-connection orgs resolve correctly, and stop gmail OAuth credentials from being misclassified against the legacy IMAP registry entry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear ticket: https://linear.app/mindsdb/issue/ENG-208/mindshub-oauth-proxy-and-data-vault
What was changed
TurnKeyDataVaultclass (satisfying the sameDataVaultprotocolLocalDataVaultdoes) fetches a live connector token fromauthusing the turn's turn key, for cloud turns only. Wired intobuild_cloud_chat_session()in place of the previousdata_vault=None. Desktop/local-mode turns are unaffected.Notes
TODO: set ANTON_CLOUD_AUTH_BASE_URL to the target environment's real auth hostname before testing there.
Related PRs