DM-2874: Prevent empty entries in SuperCombo#155
Open
dariodjuric wants to merge 2 commits into
Open
Conversation
dariodjuric
commented
Jul 3, 2026
| moveItem: MLFormList$moveItem, | ||
| setItemSchema: MLFormList$setItemSchema, | ||
| destroy: MLFormList$destroy | ||
| destroy: MLFormList$destroy, |
Author
There was a problem hiding this comment.
All these changes in /dist were auto-generated, please let me know if I should exclude them? I see some previous commits have also included /dist.
There was a problem hiding this comment.
Pull request overview
This PR addresses a bug in SuperCombo where clearing a previously-typed value could still allow an empty entry to be added via the “Add” button, by ensuring empty/whitespace-only input doesn’t surface the Add UI state and cannot be submitted.
Changes:
- Reset the internal “show Add on click” state when the input becomes empty, preventing the Add button from reappearing after clearing.
- Trim and validate the Add button payload so blank/whitespace-only labels are not posted.
- Update built
dist/*artifacts to reflect the source changes (note: the dist bundle also includes additional non‑SuperCombo code changes).
Reviewed changes
Copilot reviewed 1 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/components/SuperCombo.js | Prevents Add-button reappearance after clearing input; trims/blocks empty labels on add. |
| dist/milo_ui.min.js | Rebuilt minified output reflecting the updated component behavior. |
| dist/milo_ui.bundle.js | Rebuilt bundle reflecting SuperCombo updates; also includes additional unrelated module changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gennady-verbitsky
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: DM-2874
Fixed a bug where an empty entry could be added in the type-and-add dropdowns: after typing a name and then clearing it, the "Add" button could reappear and, when clicked, save a blank entry. Now the field ignores empty or whitespace-only input, and the "Add" option no longer shows up once the box has been cleared.