Repository navigation
chore: delete the unused Userback widget configuration rows - #963
Merged
Merged
Conversation
The Userback widget is removed from eform-angular-frontend. Stop seeding ApplicationSettings:IsUserbackWidgetEnabled and ApplicationSettings:UserbackToken and delete the rows from existing databases with a new migration. Down restores the rows with an empty token. The scaffolded migration also contained InsertData for the CMS menu rows, which 20260319062110_AddCmsMenuItem already inserts with raw SQL; those were trimmed out, as in the previous migrations. closes #962 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The migration, snapshot, seed changes, and focused tests consistently implement the requested removal.
Review effort: Balanced
Findings: None
What changed in this PR
Removes obsolete Userback widget configuration from seed data and existing databases.
Changes:
- Removes both Userback settings from configuration seeds.
- Adds a reversible migration to delete and safely restore the rows.
- Updates migration metadata and adds coverage for seed and migration behavior.
| File | Description |
|---|---|
BaseDbContextModelSnapshot.cs |
Removes Userback seed entries and updates EF version metadata. |
20260930102540_RemoveUserbackWidgetSettings.Designer.cs |
Defines the migration target model. |
20260930102540_RemoveUserbackWidgetSettings.cs |
Deletes or restores the Userback rows. |
ConfigurationSeed.cs |
Stops seeding Userback settings. |
RemoveUserbackWidgetSettingsTests.cs |
Tests seed removal and migration round-trip behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #962
The Userback widget is being removed from the product (microting/eform-angular-frontend#8097).
ConfigurationSeed: stop seedingApplicationSettings:IsUserbackWidgetEnabledandApplicationSettings:UserbackToken.20260930102540_RemoveUserbackWidgetSettings:Updeletes both rows;Downrestores them withfalseand an empty token.Hand-trimmed scaffold:
dotnet ef migrations addalso emittedInsertDatafor the CMS menu rows (MenuTemplate/MenuItem 13 + translations). They are inHasDatabut deliberately absent from the snapshot because20260319062110_AddCmsMenuIteminserts them with idempotent raw SQL; shipping the inserts would hit duplicate keys on existing databases. Same trim as in the previous migrations (62cfe54).Release order: the host must stop reading/writing these keys before or together with the package bump — that is microting/eform-angular-frontend#8097.
Verified locally: solution builds (0 errors); new tests pass (seed has no Userback keys; migrate down → rows back with empty token → migrate up → rows gone); migrations apply on a fresh MariaDB;
Upis a no-op when the rows are already missing. Full suite: 90 passed, 2 failed — bothOAuthLoginSupportTests, which need a MariaDB on localhost:3306 that was not running locally.Note: the old token value remains in historical migrations/Designer files and git history; if it is still a live credential it needs revoking on the Userback side.
🤖 Generated with Claude Code