Persist Automation session provenance for session-list filtering by ulugbekna · Pull Request #337757 · microsoft/vscode

Ulugbek Abdullaev (ulugbekna) · 2026-09-24T17:39:58Z

Summary

Use the existing typed AHP session origin to identify Automation-created sessions instead of joining the client session list against currently available run history.

Record Automation/run origin at host session creation and preserve it through session storage, the catalogue, state, listings, notifications, protocol mappings, and client caches.
Derive the Automation marker in the shared session adapter for local, remote, and Dev Container providers; remove the local-provider run-ledger join. Keep the existing ordinary-list filter and Automation history opening behavior.
Backfill older Agent Host sessions from retained full run membership, including secondary sessions and history beyond the initial page. Persist recovered origin so classification no longer depends on retaining that history.

Compatibility and scope

Sessions without recoverable origin remain visible by design. This does not add AHP protocol fields, promotion behavior, or a new host visibility mechanism. Legacy renderer-owned Automation execution is not changed by this PR.

Validation

Previously executed on this patch:

Electron unit tests: 575 passing, 18 pre-existing pending.
npm run transpile-client and npm run typecheck-client passed.
Targeted ESLint for all 24 changed TypeScript files passed.
git diff --check passed; pre-commit hygiene passed when committing.

Tests cover host creation and persistence, restart and historical recovery, deletion races, protocol and cache propagation, ordinary-list exclusion, and history opening. No live Agents Window walkthrough or real remote/Dev Container end-to-end validation was performed.

Outstanding review findings

This draft publishes the current implementation as-is. These findings from the static Opus 5.5 review remain unresolved:

P2: Isolate catalogue-backed listing backfill failures, so one deleted session or failed migration cannot reject the entire listing.
P3: Preserve existing metadata overlays when origin resolution fails, instead of dropping persisted title/read/archive state and other metadata.
P3: Keep existing-session restoration available when a non-deletion provenance backfill write fails.

Carry existing AHP automation origins from creation through persistence, listings, notifications, and client caches. Classify sessions from host-owned provenance instead of joining the client run ledger, with evidence-based backfill for retained host history. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Preserve Automation session provenance while integrating upstream catalogue metadata, protocol, and provider test changes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Copilot review overview

🔵 Needs a closer look

Provenance backfill failures can break listings or restoration, discard metadata overlays, and leave a downgrade-recovery path dependent on retained run history.

Review effort: Balanced
Findings: None

What changed in this PR

Persists Agent Host Automation provenance so Sessions can reliably classify and filter Automation-created sessions without relying on run history.

Changes:

Persists and recovers typed SessionOrigin through host storage and catalogs.
Propagates provenance through protocol, providers, state, and client caches.
Filters Automation sessions from the main list and adds regression coverage.

File	Description
`src/vs/sessions/contrib/sessions/test/browser/sessionsList.test.ts`	Tests list filtering and history opening.
`src/vs/sessions/contrib/providers/remoteAgentHost/test/browser/remoteAgentHostSessionsProvider.test.ts`	Tests remote cache persistence.
`src/vs/sessions/contrib/providers/agentHost/test/browser/localAgentHostSessionsProvider.test.ts`	Tests local origin propagation and hydration.
`src/vs/sessions/contrib/providers/agentHost/browser/localAgentHostSessionsProvider.ts`	Removes run-ledger classification.
`src/vs/sessions/contrib/providers/agentHost/browser/baseAgentHostSessionsProvider.ts`	Adapts and caches session origin.
`src/vs/sessions/AUTOMATIONS.md`	Documents provenance persistence contract.
`src/vs/platform/agentHost/test/node/protocolServerHandler.test.ts`	Tests listing protocol mapping.
`src/vs/platform/agentHost/test/node/agentService.test.ts`	Tests creation, recovery, and deletion races.
`src/vs/platform/agentHost/test/node/agentHostStateManager.test.ts`	Tests state and notification propagation.
`src/vs/platform/agentHost/test/node/agentHostCatalogSourceResolver.test.ts`	Tests metadata persistence and validation.
`src/vs/platform/agentHost/test/node/agentHostCatalogProjection.test.ts`	Tests catalog encoding and validation.
`src/vs/platform/agentHost/test/node/agentHostCatalogListReader.test.ts`	Tests catalog-only listing.
`src/vs/platform/agentHost/test/node/agentHostAutomationService.test.ts`	Tests full-history provenance recovery.
`src/vs/platform/agentHost/test/electron-browser/agentHostProtocolClient.test.ts`	Tests client protocol preservation.
`src/vs/platform/agentHost/node/shared/persistSessionMetadata.ts`	Defines the origin metadata key.
`src/vs/platform/agentHost/node/protocolServerHandler.ts`	Maps origin into list responses.
`src/vs/platform/agentHost/node/agentService.ts`	Creates, persists, backfills, and restores provenance.
`src/vs/platform/agentHost/node/agentHostStateManager.ts`	Carries origin through state summaries.
`src/vs/platform/agentHost/node/agentHostCatalogSourceResolver.ts`	Resolves persisted catalog origin.
`src/vs/platform/agentHost/node/agentHostCatalogProjection.ts`	Adds origin to catalog payloads.
`src/vs/platform/agentHost/node/agentHostCatalogListReader.ts`	Reads origin from catalog rows.
`src/vs/platform/agentHost/node/agentHostAutomationService.ts`	Indexes retained run membership.
`src/vs/platform/agentHost/common/state/sessionState.ts`	Copies origin into session state.
`src/vs/platform/agentHost/common/agent.ts`	Extends session metadata with origin.
`src/vs/platform/agentHost/browser/agentHostProtocolClient.ts`	Maps listed origin into client metadata.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Forward the existing catalogue row, including a known missing row, into provenance resolution instead of reading it again during fallback listing. Preserve the one-read coalescing invariant and cover catalogue results independently of listing eligibility. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Preserve metadata overlays and session restoration when optional provenance backfill fails, and omit concurrently deleted entries without rejecting the entire listing. Cover the failure paths and configure catalog test modes before provider registration. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

An eligible row's origin backfill already synchronizes the session database and catalogue. Do not dirty the row again and trigger another provider metadata read. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Version the provenance-aware projection so older origin-less rows cannot hide persisted origin on the first listing. Preserve old central-only metadata through migration-only decoding and verify that repaired listings return to the catalogue-only fast path. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Copilot review overview

🟡 Changes recommended

Invalidating all v1 catalog rows can make existing sessions disappear when provider metadata is temporarily unavailable.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 1

Open (1)

Preserve v1 catalog sessions during asynchronous migration · New


-export const AGENT_HOST_CATALOG_PAYLOAD_VERSION = 1;
+// Version 1 writers did not consult persisted session origin before projecting a row.
+export const AGENT_HOST_CATALOG_PAYLOAD_VERSION = 2;


Keep validated v1 catalogue metadata available to the fallback reader until provider migration completes. Preserve ordinary central-only session titles, read/archive state and multi-root metadata without unnecessary provider metadata reads. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Resolve conflicts on top of upstream remote-session delegation while retaining Automation origin persistence and regression coverage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Copilot review overview

🟡 Changes recommended

Three correctness gaps can misclassify sessions or leave Automation-created sessions inaccessible.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 4

Open (4)

Handle deleted Automation definitions without orphaning sessions · New
Atomically link Automation provenance with persisted session state · New
Validate session and provider identity before accepting catalogue payloads · New
Preserve v1 catalog sessions during asynchronous migration

+		for (const run of this._runs.values()) {
+			const origin: SessionOrigin = { kind: SessionOriginKind.Automation, automation: run.automation, run: run.resource };
+			for (const session of run.sessions) {
+				this._legacySessionOrigins.set(session, origin);
+			}


+			}, {
+				kind: SessionOriginKind.Automation,
+				automation: run.automation,
+				run: run.resource,
 			}),


+			const decoded = catalog && decodeAgentHostCatalogPayload(catalog.payload, { forMigration: true });
+			if (decoded && !decoded.ok) {
+				this._logService.warn(`[AgentService] Failed to read session origin from catalog for ${session}: ${decoded.error}`);
+			}
+			recovered ??= (decoded?.ok ? decoded.value.data.origin : undefined)
+				?? this._automationService.getLegacySessionOrigin(session.toString());
+			if (!recovered || (origin && (!decoded?.ok || equals(decoded.value.data.origin, origin)))) {
+				return recovered;
+			}
+			// Share the catalogue's deletion fence without recreating missing session databases.
+			return await this._catalogSyncService.runMigrationExclusive(session, async (database, synchronize) => {
+				if (await this._sessionRegistry.isTombstoned(session)) {
+					throw new ProtocolError(AHP_SESSION_NOT_FOUND, `Session not found: ${session}`);
+				}
+				const persistedOrigin = readPersistedSessionOrigin(await database?.object.getMetadata(SESSION_ORIGIN_KEY));
+				const currentCatalog = await this._orchestratorDatabase.getSessionV2(session.toString());
+				const current = currentCatalog && decodeAgentHostCatalogPayload(currentCatalog.payload, { forMigration: true });


Copilot

Copilot review overview

🔵 Needs a closer look

A failed run-link persistence can leave an Automation-marked session hidden without any run-history entry through which users can open it.

Review effort: Balanced
Findings: 4

Open (4)

Validate session and provider identity before accepting catalogue payloads
Atomically link Automation provenance with persisted session state
Handle deleted Automation definitions without orphaning sessions
Preserve v1 catalog sessions during asynchronous migration

github-actions · 2026-09-25T00:50:22Z

Screenshot Changes

Base: bdc5ebe5 Current: 8d4be7db

Changed (4)

chat/scrollAnchoring/chatScrollAnchoring/CompletedVisibleHeader/Dark

Before	After

chat/scrollAnchoring/chatScrollAnchoring/CompletedVisibleHeader/Light

Before	After

chat/scrollAnchoring/chatScrollAnchoring/CompletedOffscreenHeader/Light

Before	After

imageCarousel/imageCarousel/MultipleSections/Dark

Before	After

1 insignificant change(s) omitted (≤20 px, Δ≤2). See CI logs for details.

Copilot AI balanced review requested due to automatic review settings September 24, 2026 17:39

Copilot started reviewing on behalf of Ulugbek Abdullaev (ulugbekna) September 24, 2026 17:40 View session

automations: chore: merge main to resolve PR conflicts

0cde9b3

Preserve Automation session provenance while integrating upstream catalogue metadata, protocol, and provider test changes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI reviewed Sep 24, 2026

View reviewed changes

Ulugbek Abdullaev (ulugbekna) and others added 4 commits September 24, 2026 20:42

Ben Villalobos (benvillalobos) requested a balanced review from Copilot September 25, 2026 00:17

Copilot started reviewing on behalf of Ben Villalobos (benvillalobos) September 25, 2026 00:18 View session

Copilot AI reviewed Sep 25, 2026

View reviewed changes

Comment thread src/vs/platform/agentHost/node/agentHostCatalogProjection.ts

export const AGENT_HOST_CATALOG_PAYLOAD_VERSION = 1;

// Version 1 writers did not consult persisted session origin before projecting a row.

export const AGENT_HOST_CATALOG_PAYLOAD_VERSION = 2;

Ben Villalobos (benvillalobos) requested a balanced review from Copilot September 25, 2026 00:25

Copilot started reviewing on behalf of Ben Villalobos (benvillalobos) September 25, 2026 00:25 View session

automations: merge latest main and preserve provenance

13cc808

Resolve conflicts on top of upstream remote-session delegation while retaining Automation origin persistence and regression coverage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI reviewed Sep 25, 2026

View reviewed changes

Ben Villalobos (benvillalobos) requested a balanced review from Copilot September 25, 2026 00:34

Copilot started reviewing on behalf of Ben Villalobos (benvillalobos) September 25, 2026 00:34 View session

Copilot AI reviewed Sep 25, 2026

View reviewed changes

Navigation Menu

Persist Automation session provenance for session-list filtering - #337757

Persist Automation session provenance for session-list filtering#337757
Ulugbek Abdullaev (ulugbekna) wants to merge 8 commits into
mainfrom
agents/investigate-legacy-client-automation-removal

Ulugbek Abdullaev (ulugbekna) commented Sep 24, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

github-actions Bot commented Sep 25, 2026

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Ulugbek Abdullaev (ulugbekna) commented Sep 24, 2026

Summary

Compatibility and scope

Validation

Outstanding review findings

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🔵 Needs a closer look

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🔵 Needs a closer look

Uh oh!

github-actions Bot commented Sep 25, 2026

Screenshot Changes

Changed (4)

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants