Skip to content

Test non-blocking macOS system certificate loading - #333953

Draft
Christof Marti (chrmarti) wants to merge 2 commits into
mainfrom
chrmarti/test-macos-system-cert-worker
Draft

Test non-blocking macOS system certificate loading#333953
Christof Marti (chrmarti) wants to merge 2 commits into
mainfrom
chrmarti/test-macos-system-cert-worker

Conversation

@chrmarti

@chrmarti Christof Marti (chrmarti) commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

Summary

Pin @vscode/proxy-agent to commit 354da71 from microsoft/vscode-proxy-agent#116 so a full VS Code Product Build can validate the macOS system-certificate worker end to end.

The dependency is pinned in both the root and remote/ manifests because VS Code hygiene requires shared dependency versions to match and the remote extension host also uses the proxy agent.

This is an integration-test PR for #333830 and is not intended to merge with the Git dependency pin.

Session Context
  • The proxy-agent change moves tls.getCACertificates('system') into a worker on macOS and preloads it during proxy resolver creation.
  • The proxy-agent commit includes freshly compiled out/ files because npm Git dependencies do not run a package build for this repository.
  • The worker output is present in both installed dependency trees and has been exercised locally through the VS Code workspace.
  • The permanent VS Code dependency should return to a registry version after @vscode/proxy-agent 0.45.0 is published.

Validation

  • npm run typecheck-client
  • npm run hygiene
  • Root and remote packages resolve to @vscode/proxy-agent@0.45.0 from commit 354da71d99112721512964c9c96a7b30b102ad40.
  • Local certificate loading starts the worker, returns certificates, and logs its exit duration and code.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings September 2, 2026 09:02

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The explicitly temporary Git dependency must return to a published registry version before merge.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review tier: Balanced
Findings: None

What changed in this PR

Pins the proxy agent’s macOS certificate-worker implementation for product-build validation.

Changes:

  • References proxy-agent commit 354da71.
  • Updates the lockfile to version 0.45.0.
File Description
package.json Adds the temporary Git dependency pin.
package-lock.json Locks the corresponding commit and package metadata.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants