Test non-blocking macOS system certificate loading - #333953
Draft
Christof Marti (chrmarti) wants to merge 2 commits into
Draft
Test non-blocking macOS system certificate loading#333953Christof Marti (chrmarti) wants to merge 2 commits into
Christof Marti (chrmarti) wants to merge 2 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Christof Marti (chrmarti)
September 2, 2026 09:02
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The explicitly temporary Git dependency must return to a published registry version before merge.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: None
What changed in this PR
Pins the proxy agent’s macOS certificate-worker implementation for product-build validation.
Changes:
- References proxy-agent commit
354da71. - Updates the lockfile to version 0.45.0.
| File | Description |
|---|---|
package.json |
Adds the temporary Git dependency pin. |
package-lock.json |
Locks the corresponding commit and package metadata. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pin
@vscode/proxy-agentto commit354da71from microsoft/vscode-proxy-agent#116 so a full VS Code Product Build can validate the macOS system-certificate worker end to end.The dependency is pinned in both the root and
remote/manifests because VS Code hygiene requires shared dependency versions to match and the remote extension host also uses the proxy agent.This is an integration-test PR for #333830 and is not intended to merge with the Git dependency pin.
Session Context
tls.getCACertificates('system')into a worker on macOS and preloads it during proxy resolver creation.out/files because npm Git dependencies do not run a package build for this repository.@vscode/proxy-agent0.45.0 is published.Validation
npm run typecheck-clientnpm run hygiene@vscode/proxy-agent@0.45.0from commit354da71d99112721512964c9c96a7b30b102ad40.