chore(ci): remove squash requirement - #333892
Draft
Raymond Zhao (rzhao271) wants to merge 1 commit into
Draft
Conversation
Raymond Zhao (rzhao271)
commented
Sep 1, 2026
Raymond Zhao (rzhao271)
commented
Collaborator
- Tested on ADO
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Manually queued builds now unintentionally bypass trailer validation.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Removes the squash requirement while retaining MSRC trailer validation.
Changes:
- Supports multi-commit PRs.
- Requires at least one valid
Msrc-Case-Idtrailer. - Skips validation for non-PR builds.
File summaries
| File | Description |
|---|---|
build/azure-pipelines/product-build-ado-ci.yml |
Updates commit-trailer validation logic. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+263
to
+267
| # Only validate trailers for PR builds | ||
| if [ "$(Build.Reason)" != "PullRequest" ]; then | ||
| echo "Skipping trailer check for non-PR builds" | ||
| exit 0 | ||
| fi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.