fix: survey scroll - move padding from scroll container to form content#322329
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the “clipped submit button” issue in the Surveys editor pane by ensuring the bottom spacing is part of the scrollable content, avoiding the known flex + scroll-container padding inconsistency across browsers.
Changes:
- Change the scroll container to use
overflow-y: auto(vertical scrolling explicitly). - Move the
padding: 40px 20px 80pxfrom.survey-editor-pane(scroll container) to.survey-form(scroll content), so the padding reliably contributes to scroll extent.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/surveys/browser/media/surveyEditorPane.css | Moves padding to the scroll content element to make bottom spacing reliably scrollable and avoid submit button clipping. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
digitarald
force-pushed
the
digitarald/fix-survey-scroll
branch
3 times, most recently
from
4354f29 to
64de92b
Compare
- Move padding from scroll container to .survey-form child to permanently fix clipped submit button (flex+overflow CSS issue) - Only Q1 (disappointment score) is required for submission; Q2-Q4 are optional. Submit enables as soon as Q1 is answered. - Add italic '(optional)' annotation after Q2-Q4 question labels - aria-required only set on required question groups - Rename escape options from 'Something else' to 'None of the above' - Updated hint text and a11y help to reflect optional questions Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
digitarald
force-pushed
the
digitarald/fix-survey-scroll
branch
from
64de92b to
f7c4839
Compare
dbaeumer
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up fixes for the in-editor PMF survey (#322192).
Changes
Fix scroll clipping: Move padding from the scroll container (
.survey-editor-pane) to the content child (.survey-form). Bottom padding on a flex container withoverflow: autois not reliably included in the scrollable area — this is the root cause of the repeatedly-broken submit button visibility.Only Q1 required: Submit button enables as soon as the PMF score (Q1) is answered. Q2–Q4 are optional — unanswered fields emit defaults in telemetry. Added
requiredproperty to the question schema.Optional annotations: Questions 2–4 show
(optional)in the label text.Escape option labels: Renamed from "Something else" to "None of the above" for Q2 and Q3.
a11y alignment:
aria-requiredonly set on required question groups. Updated hint text and accessible help dialog.