Skip to content

chat: simplify Agent Host Copilot label#322179

Merged
roblourens merged 6 commits into
mainfrom
agents/copilot-agent-naming-clarification-44d30d22
Jun 20, 2026
Merged

chat: simplify Agent Host Copilot label#322179
roblourens merged 6 commits into
mainfrom
agents/copilot-agent-naming-clarification-44d30d22

Conversation

@roblourens

@roblourens roblourens commented Jun 19, 2026

Copy link
Copy Markdown
Member

Fix #322193

Summary

  • rename the local Agent Host Copilot descriptor display name from "Copilot CLI" to "Copilot"
  • preserve the stable provider id/session type (copilotcli) so routing and stored sessions do not change
  • keep the editor-window Agent Host suffix for other local agent host providers while leaving Copilot unadorned
  • simplify redundant label plumbing now that Copilot advertises the desired display name at the source

Testing

  • npm run typecheck-client
  • npm run valid-layers-check
  • npm run gulp compile
  • ./scripts/test.sh --run src/vs/platform/agentHost/test/node/copilotAgent.test.ts --run src/vs/workbench/contrib/chat/test/browser/agentSessions/agentHostChatContribution.test.ts --run src/vs/sessions/contrib/providers/agentHost/test/browser/localAgentHostSessionsProvider.test.ts
  • ./scripts/test.sh --run src/vs/workbench/contrib/chat/test/browser/agentSessions/agentHostChatContribution.test.ts --run src/vs/sessions/contrib/providers/agentHost/test/browser/localAgentHostSessionsProvider.test.ts --run src/vs/sessions/contrib/providers/remoteAgentHost/test/browser/remoteAgentHostSessionsProvider.test.ts
  • npm run precommit

(Written by Copilot)

Use the shorter Copilot label for the Agent Host Copilot session when the local editor agent is disabled, while keeping the Agent Host-disambiguated name when both implementations can appear. (Written by Copilot)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings June 19, 2026 23:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Agent Host “Copilot” provider naming so it can display as “Copilot” when chat.editor.localAgent.enabled is disabled, while preserving the disambiguated label when both Copilot implementations may appear. The change is applied across key UI surfaces (picker, hover, filter, Agents window) and verified with additional unit tests.

Changes:

  • Extend getAgentSessionProviderName to optionally consult configuration and conditionally simplify the Agent Host Copilot label.
  • Thread IConfigurationService through relevant workbench UI components so labels remain consistent (picker, hover, filter, model).
  • Update agent-host session providers and tests to use the conditional naming behavior.
Show a summary per file
File Description
src/vs/workbench/contrib/chat/test/browser/agentSessions/agentSessionViewModel.test.ts Adds a unit test ensuring Agent Host Copilot name simplifies to “Copilot” when the editor local agent is disabled.
src/vs/workbench/contrib/chat/test/browser/agentSessions/agentHostChatContribution.test.ts Adds coverage that the Agent Host contribution advertises the simplified display name under the disabled setting.
src/vs/workbench/contrib/chat/electron-browser/chat.contribution.ts Passes configuration into provider-name resolution when opening new Agent Host sessions.
src/vs/workbench/contrib/chat/browser/widget/input/sessionTargetPickerActionItem.ts Uses configuration-aware provider naming for session-type picker labels.
src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatSuggestNextWidget.ts Uses configuration-aware provider naming for “Continue in …” action labels.
src/vs/workbench/contrib/chat/browser/chatSessions/chatSessions.contribution.ts Adjusts in-place session action labels to prefer contribution displayName for Agent Host Copilot.
src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsModel.ts Injects configuration and uses it to compute provider labels for known providers.
src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsFilter.ts Injects configuration and uses it to compute provider labels in the filter menu.
src/vs/workbench/contrib/chat/browser/agentSessions/agentSessions.ts Adds optional configuration parameter to getAgentSessionProviderName and introduces the simplified “Copilot” label for Agent Host Copilot when configured.
src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionHoverWidget.ts Uses configuration-aware provider naming in hover UI.
src/vs/workbench/contrib/chat/browser/agentSessions/agentHost/agentHostChatContribution.ts Centralizes Agent Host agent display name logic and aligns handler fullName/displayName with conditional provider naming for Copilot.
src/vs/workbench/contrib/chat/browser/actions/chatContinueInAction.ts Ensures the continue-in dropdown label selection prefers contribution displayName for Agent Host Copilot.
src/vs/sessions/contrib/providers/remoteAgentHost/browser/remoteAgentHostSessionsProvider.ts Updates override signature for session type label formatting to include provider id.
src/vs/sessions/contrib/providers/agentHost/browser/localAgentHostSessionsProvider.ts Special-cases copilotcli provider to use configuration-aware Agent Host Copilot naming.
src/vs/sessions/contrib/providers/agentHost/browser/baseAgentHostSessionsProvider.ts Extends session-type label formatting to include provider id and wires it through session-type sync.
.github/skills/sessions/SKILL.md Documents a review guideline to avoid live config listeners for one-time label reads.

Copilot's findings

  • Files reviewed: 16/16 changed files
  • Comments generated: 0

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
roblourens and others added 2 commits June 19, 2026 18:52
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
(Written by Copilot)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

  • Files reviewed: 13/13 changed files
  • Comments generated: 1

roblourens and others added 2 commits June 19, 2026 20:45
(Written by Copilot)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
(Written by Copilot)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@roblourens roblourens marked this pull request as ready for review June 20, 2026 04:34
@roblourens roblourens enabled auto-merge (squash) June 20, 2026 04:34
@roblourens roblourens merged commit 8c2e536 into main Jun 20, 2026
28 checks passed
@roblourens roblourens deleted the agents/copilot-agent-naming-clarification-44d30d22 branch June 20, 2026 05:18
@vs-code-engineering vs-code-engineering Bot added this to the 1.126.0 milestone Jun 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename AH session type to 'Copilot'

3 participants