Display model name in subagent session#322048
Open
sukumarp2022 wants to merge 5 commits into
Open
Conversation
Author
|
@microsoft-github-policy-service agree |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the VS Code Chat subagent content part by surfacing the subagent’s model name in the collapsible title UI and ensuring the same information is reflected in the collapse button’s accessible label. It also introduces a dedicated CSS hook for styling the model label and adds browser-widget tests to cover the new behaviors.
Changes:
- Render the subagent model name inline in the title (active + completed) and incorporate it into the computed
aria-label. - Make
ChatCollapsibleContentPart.updateAriaLabeloverridable (protected) and override it in the subagent part to centralize aria-label generation. - Add tests validating model-name rendering, aria-label behavior, and non-duplication across updates.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/test/browser/widget/chatContentParts/chatSubagentContentPart.test.ts | Adds test coverage for model name display and aria-label updates across states. |
| src/vs/workbench/contrib/chat/browser/widget/chatContentParts/media/chatSubagentContent.css | Adds .chat-subagent-model-label styling for the inline model label. |
| src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatSubagentContentPart.ts | Implements inline model label rendering and centralized aria-label generation, plus update plumbing. |
| src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatCollapsibleContentPart.ts | Makes updateAriaLabel protected to support subclass overrides. |
Copilot's findings
- Files reviewed: 4/4 changed files
- Comments generated: 1
Address review comment: modelNameChanged now detects when modelName is removed/cleared (not just when a new value arrives), and updateHover() properly disposes the hover tooltip when modelName becomes undefined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes - #321923
This pull request improves the Chat subagent UI by displaying the model name used by a subagent inline in the title and ensuring it is included in accessibility labels. It also adds comprehensive tests to verify this behavior and introduces a dedicated CSS class for consistent styling of the model label.
UI improvements:
chatSubagentContentPart.ts,chatSubagentContent.css) [1] [2] [3] [4] [5]Accessibility improvements:
aria-labelfor the collapse button, ensuring screen readers announce the model being used. The logic for generating the aria label is centralized and updated whenever the title changes. (chatSubagentContentPart.ts)Code structure & maintainability:
updateAriaLabelmethod is madeprotectedin the base class to allow for overriding, and is overridden in the subagent part to use the new aria label logic. (chatCollapsibleContentPart.ts,chatSubagentContentPart.ts) [1] [2]Testing:
chatSubagentContentPart.test.ts)