Skip to content

chore: bump electron@42.5.0#321629

Merged
deepak1556 merged 12 commits into
mainfrom
robo/update_electron
Jun 29, 2026
Merged

chore: bump electron@42.5.0#321629
deepak1556 merged 12 commits into
mainfrom
robo/update_electron

Conversation

@deepak1556

@deepak1556 deepak1556 commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

@deepak1556 deepak1556 added this to the 1.126.0 milestone Jun 16, 2026
@deepak1556 deepak1556 self-assigned this Jun 16, 2026
Copilot AI review requested due to automatic review settings June 16, 2026 16:16

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates VS Code’s pinned Electron version to 42.4.0 and aligns related build inputs (Chromium revision, Node version, checksums, and packaging dependency baselines) to keep the build and compliance metadata consistent.

Changes:

  • Bump electron dependency to 42.4.0 and update lockfile accordingly.
  • Update Node to 24.16.0 (repo + Copilot extension) and refresh Node/Electron checksum manifests.
  • Align Chromium references and Linux packaging dependency references to the newer upstream baseline.

Reviewed changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
remote/.npmrc Updates remote/node build target and MS build id to Node 24.16.0 inputs.
package.json Bumps Electron dependency to 42.4.0.
package-lock.json Updates Electron package resolution and transitive dependencies for 42.4.0.
extensions/copilot/.nvmrc Aligns Copilot extension dev Node version to 24.16.0.
cgmanifest.json Updates Chromium/Node/Electron component versions and commit hashes for compliance tracking.
build/linux/dependencies-generator.ts Updates the upstream Chromium reference URL used for dependency generation guidance.
build/linux/debian/dep-lists.ts Adjusts reference Debian dependency list to match newly generated dependencies.
build/lib/electron.ts Removes hardcoded Electron version and reads version/build id from .npmrc via util.
build/checksums/nodejs.txt Refreshes Node 24.16.0 artifact checksums.
build/checksums/electron.txt Refreshes Electron 42.4.0 artifact checksums.
build/azure-pipelines/linux/setup-env.sh Updates Chromium revision used to fetch clang/toolchain scripts in CI.
.nvmrc Updates repo dev Node version to 24.16.0.
.npmrc Updates Electron headers target and MS build id to 42.4.0 inputs.

@deepak1556
deepak1556 force-pushed the robo/update_electron branch from 0c62aa1 to 0619f12 Compare June 16, 2026 19:02
@deepak1556
deepak1556 marked this pull request as ready for review June 16, 2026 19:02
@vs-code-engineering

vs-code-engineering Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@lszomoru

Matched files:

  • build/azure-pipelines/linux/setup-env.sh

@deepak1556
deepak1556 enabled auto-merge (squash) June 16, 2026 19:07
Yoyokrazy
Yoyokrazy previously approved these changes Jun 16, 2026
TylerLeonhardt
TylerLeonhardt previously approved these changes Jun 17, 2026
@deepak1556
deepak1556 force-pushed the robo/update_electron branch from 2aad61e to 6d0ca47 Compare June 17, 2026 04:54
@deepak1556
deepak1556 marked this pull request as draft June 17, 2026 04:54
auto-merge was automatically disabled June 17, 2026 04:54

Pull request was converted to draft

@deepak1556

Copy link
Copy Markdown
Collaborator Author

I couldn't repro the failure locally only to find this in the CI test resolver logs

Assertion failed: !_wcsnicmp(filename, dir, dirlen), file src\win\fs-event.c, line 72
Remote socket closed, closing proxy socket.
Proxy socket closed, closing remote socket.
Remote socket closed, closing proxy socket.
Proxy socket closed, closing remote socket.
server closed unexpectedly.

Already tracked regression in upstream nodejs/node#63638

@deepak1556
deepak1556 force-pushed the robo/update_electron branch 3 times, most recently from b366537 to 7b6063a Compare June 18, 2026 22:14
@aiday-mar aiday-mar removed this from the 1.126.0 milestone Jun 24, 2026
@deepak1556
deepak1556 force-pushed the robo/update_electron branch from 7b6063a to 28a9c08 Compare June 26, 2026 13:48
@arempe93

Copy link
Copy Markdown

this would be great to get in for the node version update. the currently used Node v24.15.0 can cause issues with extensions for Yarn PnP users, depending on your Yarn version.

@deepak1556 deepak1556 changed the title chore: bump electron@42.4.0 chore: bump electron@42.5.0 Jun 28, 2026
@deepak1556
deepak1556 force-pushed the robo/update_electron branch 4 times, most recently from d014911 to 9fe49ac Compare June 29, 2026 03:51
@deepak1556 deepak1556 added this to the 1.128.0 milestone Jun 29, 2026
@deepak1556
deepak1556 force-pushed the robo/update_electron branch from 9fe49ac to 4891498 Compare June 29, 2026 05:28
@deepak1556

Copy link
Copy Markdown
Collaborator Author

@github-actions

github-actions Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Screenshot Changes

Base: b802a62b Current: a7bd7957

Changed (49)

sessions/agentFeedback/agentFeedbackEditorOverlayWidget/ZeroOfZero/Dark
Before After
before after
sessions/agentFeedback/agentFeedbackEditorOverlayWidget/ZeroOfZero/Light
Before After
before after
sessions/agentFeedback/agentFeedbackEditorOverlayWidget/SingleFeedback/Dark
Before After
before after
sessions/agentFeedback/agentFeedbackEditorOverlayWidget/SingleFeedback/Light
Before After
before after
sessions/agentFeedback/agentFeedbackEditorOverlayWidget/FirstOfThree/Dark
Before After
before after
sessions/agentFeedback/agentFeedbackEditorOverlayWidget/FirstOfThree/Light
Before After
before after
sessions/agentFeedback/agentFeedbackEditorOverlayWidget/ReviewOnlyTwoComments/Dark
Before After
before after
sessions/agentFeedback/agentFeedbackEditorOverlayWidget/ReviewOnlyTwoComments/Light
Before After
before after
sessions/agentFeedback/agentFeedbackEditorOverlayWidget/MiddleOfThree/Dark
Before After
before after
sessions/agentFeedback/agentFeedbackEditorOverlayWidget/MixedFourComments/Dark
Before After
before after
sessions/agentFeedback/agentFeedbackEditorOverlayWidget/MixedFourComments/Light
Before After
before after
sessions/agentFeedback/agentFeedbackEditorOverlayWidget/LastOfThree/Dark
Before After
before after
sessions/inputBanners/sessionInputBanners/PRComments/Dark
Before After
before after
sessions/inputBanners/sessionInputBanners/LongTextEllipsis/Dark
Before After
before after
sessions/inputBanners/sessionInputBanners/LongTextEllipsis/Light
Before After
before after
sessions/chatCompositeBar/TwoChats/Dark
Before After
before after
sessions/chatCompositeBar/TwoChats/Light
Before After
before after
sessions/chatCompositeBar/MixedStatuses/Dark
Before After
before after
sessions/chatCompositeBar/MixedStatuses/Light
Before After
before after
sessions/chatCompositeBar/LongTitles/Dark
Before After
before after
sessions/chatCompositeBar/LongTitles/Light
Before After
before after
sessions/chatCompositeBar/Renaming/Dark
Before After
before after
sessions/chatCompositeBar/Renaming/Light
Before After
before after
sessions/chatCompositeBar/WithDraftChat/Dark
Before After
before after
sessions/chatCompositeBar/WithDraftChat/Light
Before After
before after
sessions/openPullRequest/OpenPullRequest_Open/Dark
Before After
before after
sessions/openPullRequest/OpenPullRequest_Open/Light
Before After
before after
sessions/openPullRequest/OpenPullRequest_Draft/Dark
Before After
before after
sessions/openPullRequest/OpenPullRequest_Draft/Light
Before After
before after
sessions/viewAllChanges/ViewAllChanges_SingleFile/Dark
Before After
before after
sessions/viewAllChanges/ViewAllChanges_SingleFile/Light
Before After
before after
sessions/viewAllChanges/ViewAllChanges_MultipleFiles/Dark
Before After
before after
sessions/viewAllChanges/ViewAllChanges_MultipleFiles/Light
Before After
before after
sessions/viewAllChanges/ViewAllChanges_OnlyInsertions/Dark
Before After
before after
sessions/viewAllChanges/ViewAllChanges_OnlyInsertions/Light
Before After
before after
sessions/viewAllChanges/ViewAllChanges_OnlyDeletions/Dark
Before After
before after
sessions/viewAllChanges/ViewAllChanges_OnlyDeletions/Light
Before After
before after
sessions/viewAllChanges/ViewAllChanges_NoChanges/Dark
Before After
before after
sessions/viewAllChanges/ViewAllChanges_NoChanges/Light
Before After
before after
baseUI/Buttons/Dark
Before After
before after
baseUI/Buttons/Light
Before After
before after
imageCarousel/imageCarousel/SingleSection/Dark
Before After
before after
imageCarousel/imageCarousel/SingleSection/Light
Before After
before after
imageCarousel/imageCarousel/SingleSectionMiddleImage/Dark
Before After
before after
imageCarousel/imageCarousel/SingleSectionMiddleImage/Light
Before After
before after
imageCarousel/imageCarousel/MultipleSections/Dark
Before After
before after
imageCarousel/imageCarousel/MultipleSections/Light
Before After
before after
imageCarousel/imageCarousel/SingleImage/Dark
Before After
before after
imageCarousel/imageCarousel/SingleImage/Light
Before After
before after

453 insignificant change(s) omitted (≤20 px, Δ≤2). See CI logs for details.

deepak1556 and others added 10 commits June 29, 2026 18:58
Node 24.16+ made Readable pause()/resume() a no-op on destroyed streams
which makes yauzl 2.x / extract-zip 2.x and older playwright extraction
hang forever.

- extensions/copilot: add "yauzl": "^3.3.1" override (was missed by #318682)
  so electron and @vscode/vsce no longer resolve the broken yauzl 2.10, fixing the
  hung `npm ci` in the Copilot and Extract chat-lib pipelines.
- extensions/copilot: bump electron ^39.8.5 -> ^42.5.0 so its install
  script uses the native @electron-internal/extract-zip instead of extract-zip.
- bump @playwright/test ^1.56.1 -> ^1.61.1 so `playwright install`
  uses the fixed extractor, unblocking the "Download Electron and
  Playwright" step in all electron test pipelines.
On macOS CI, the AgentHost sandbox smoke test resolves the shell to
/bin/sh, which uses the sentinel-based completion path. In that path, the
parser could consume the echoed sentinel command text
(`<<<COPILOT_SENTINEL_..._EXIT_$?>>>`) before the real numeric marker
arrived, causing a false `Exit code: -1` failure even though the command
later completed successfully.

Harden the sentinel parser to ignore echoed/non-numeric sentinel text
and use the latest complete numeric marker instead. Also force the
macOS AgentHost sandbox smoke test to use /bin/sh and assert that in the
suite log so local runs exercise the same path as CI.

Adds a regression test for echoed sentinel command text.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@deepak1556
deepak1556 force-pushed the robo/update_electron branch from 4891498 to 191e6ae Compare June 29, 2026 10:01
@deepak1556
deepak1556 marked this pull request as ready for review June 29, 2026 13:31
@deepak1556
deepak1556 enabled auto-merge (squash) June 29, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Integrated Browser Dev Tools Network panel missing most requests

7 participants