chore: bump electron@42.5.0#321629
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates VS Code’s pinned Electron version to 42.4.0 and aligns related build inputs (Chromium revision, Node version, checksums, and packaging dependency baselines) to keep the build and compliance metadata consistent.
Changes:
- Bump electron dependency to
42.4.0and update lockfile accordingly. - Update Node to
24.16.0(repo + Copilot extension) and refresh Node/Electron checksum manifests. - Align Chromium references and Linux packaging dependency references to the newer upstream baseline.
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| remote/.npmrc | Updates remote/node build target and MS build id to Node 24.16.0 inputs. |
| package.json | Bumps Electron dependency to 42.4.0. |
| package-lock.json | Updates Electron package resolution and transitive dependencies for 42.4.0. |
| extensions/copilot/.nvmrc | Aligns Copilot extension dev Node version to 24.16.0. |
| cgmanifest.json | Updates Chromium/Node/Electron component versions and commit hashes for compliance tracking. |
| build/linux/dependencies-generator.ts | Updates the upstream Chromium reference URL used for dependency generation guidance. |
| build/linux/debian/dep-lists.ts | Adjusts reference Debian dependency list to match newly generated dependencies. |
| build/lib/electron.ts | Removes hardcoded Electron version and reads version/build id from .npmrc via util. |
| build/checksums/nodejs.txt | Refreshes Node 24.16.0 artifact checksums. |
| build/checksums/electron.txt | Refreshes Electron 42.4.0 artifact checksums. |
| build/azure-pipelines/linux/setup-env.sh | Updates Chromium revision used to fetch clang/toolchain scripts in CI. |
| .nvmrc | Updates repo dev Node version to 24.16.0. |
| .npmrc | Updates Electron headers target and MS build id to 42.4.0 inputs. |
0c62aa1 to
0619f12
Compare
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @lszomoruMatched files:
|
2aad61e to
6d0ca47
Compare
Pull request was converted to draft
|
I couldn't repro the failure locally only to find this in the CI test resolver logs Already tracked regression in upstream nodejs/node#63638 |
b366537 to
7b6063a
Compare
7b6063a to
28a9c08
Compare
|
this would be great to get in for the node version update. the currently used Node |
d014911 to
9fe49ac
Compare
9fe49ac to
4891498
Compare
Screenshot ChangesBase: Changed (49)453 insignificant change(s) omitted (≤20 px, Δ≤2). See CI logs for details. |
Node 24.16+ made Readable pause()/resume() a no-op on destroyed streams which makes yauzl 2.x / extract-zip 2.x and older playwright extraction hang forever. - extensions/copilot: add "yauzl": "^3.3.1" override (was missed by #318682) so electron and @vscode/vsce no longer resolve the broken yauzl 2.10, fixing the hung `npm ci` in the Copilot and Extract chat-lib pipelines. - extensions/copilot: bump electron ^39.8.5 -> ^42.5.0 so its install script uses the native @electron-internal/extract-zip instead of extract-zip. - bump @playwright/test ^1.56.1 -> ^1.61.1 so `playwright install` uses the fixed extractor, unblocking the "Download Electron and Playwright" step in all electron test pipelines.
On macOS CI, the AgentHost sandbox smoke test resolves the shell to /bin/sh, which uses the sentinel-based completion path. In that path, the parser could consume the echoed sentinel command text (`<<<COPILOT_SENTINEL_..._EXIT_$?>>>`) before the real numeric marker arrived, causing a false `Exit code: -1` failure even though the command later completed successfully. Harden the sentinel parser to ignore echoed/non-numeric sentinel text and use the latest complete numeric marker instead. Also force the macOS AgentHost sandbox smoke test to use /bin/sh and assert that in the suite log so local runs exercise the same path as CI. Adds a regression test for echoed sentinel command text. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
4891498 to
191e6ae
Compare
Fixes #320157
Refs https://releases.electronjs.org/release/compare/v42.2.0/v42.5.0