Skip to content

Use shared Python version check action - #26271

Open
Eduardo Villalpando Mello (edvilme) wants to merge 3 commits into
mainfrom
shared-python-version-action
Open

Eduardo Villalpando Mello (edvilme) wants to merge 3 commits into
mainfrom
shared-python-version-action

Conversation

@edvilme

@edvilme Eduardo Villalpando Mello (edvilme) commented Nov 4, 2026 •

Copy link
Copy Markdown

Summary

  • Replace the duplicated weekly Python version checker and shell issue-creation steps with the shared action from microsoft/pylance-engineering#4, pinned to c1aa1190277c85c93ab142e8909bcd11453ce30b.
  • Supply explicit workflow paths and Python matrix keys.
  • Preserve the Monday schedule, manual dispatch, checkout pin, repository-owner guard, permissions, concurrency, and debt / python-version issue labels.
  • Remove the obsolete local checker and its tests; the shared action owns the implementation and unit tests.

Validation

  • Prettier passes for the changed workflow; YAML parsing and git diff --check pass.
  • Exercised the pinned checker in check-only mode against the actual configured workflows using Python.org release data.
  • Verified coverage matches the previous checker across all seven migrations: 14 workflows and 19 explicit matrices.
  • Verified issue creation arguments, repository, labels, and token forwarding with a mocked subprocess. No live issues were created.
  • The shared action's post-merge CI passed.

Behavior change

The shared action intentionally defers duplicate-issue detection. Issue creation remains enabled, so each scheduled/manual run with missing coverage creates an issue even if one already exists or was previously closed. Concurrency prevents overlapping runs, not duplicates across runs.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 956d3afd-ae0b-486c-a60c-3a6276c23213
@edvilme Eduardo Villalpando Mello (edvilme) added the debt Code quality issues label Nov 4, 2026
Use microsoft/vscode-python-ci after the shared action repository rename. Preserve the existing action commit pin and workflow configuration.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 956d3afd-ae0b-486c-a60c-3a6276c23213
@edvilme

Copy link
Copy Markdown
Author

Summary

Update the shared Python version checker reference from microsoft/pylance-engineering to microsoft/vscode-python-ci after the source repository rename.

Preserves the reviewed commit pin a81ceb5dc25ea56bd0c957ccda3a48886682faea, all inputs, permissions, triggers, and issue behavior. No GitHub App credentials are introduced.

Validation

  • Existing Prettier check passed.
  • Workflow YAML and configured input paths validated.
  • Exact reference-only diff and git diff --check passed.
  • Authenticated API confirms the action exists at the pinned commit in the renamed repository.

Deployment prerequisite

At publication time, GitHub still reports microsoft/vscode-python-ci as private, and anonymous access to the pinned action returns HTTP 404. The source must be public before public consumer workflows can resolve this action. No repository visibility settings were changed by this PR.

Use c1aa1190277c85c93ab142e8909bcd11453ce30b from microsoft/vscode-python-ci.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 956d3afd-ae0b-486c-a60c-3a6276c23213
@edvilme

Copy link
Copy Markdown
Author

Pin correction: the action now references microsoft/vscode-python-ci@c1aa119, superseding the SHA in my earlier comment. Verified the action files at that commit and its successful source CI run: https://github.com/microsoft/vscode-python-ci/actions/runs/41917460225 . All seven consumers passed YAML, pin-only diff, whitespace, and Prettier checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

debt Code quality issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants