Skip to content

build: limit PR validation to CFS restores - #1932

Merged
wenyt (wenytang-ms) merged 1 commit into
mainfrom
build/cfs-restore-only-pr-validation
Sep 10, 2026
Merged

build: limit PR validation to CFS restores#1932
wenyt (wenytang-ms) merged 1 commit into
mainfrom
build/cfs-restore-only-pr-validation

Conversation

@wenytang-ms

Copy link
Copy Markdown
Contributor

Summary

  • run pull request validation only through the CFS-backed npm and Maven restore/build steps
  • skip lint, extension prepublish, VSIX packaging, and artifact publication for pull requests
  • preserve the existing full build and packaging behavior for non-PR runs, including commits to main
  • trigger validation when npm/Maven dependency inputs or the CFS pipeline configuration changes

Why

#1929 enabled path-filtered CFS validation by reusing the full CI pipeline. A validation run confirmed that npm and Maven restore succeeded, but later failed in the unrelated npx @vscode/vsce@latest package step because the CI image currently exposes Node 18 while the latest vsce dependencies require Node 20.

The purpose of the PR check is to verify that dependency versions can be restored from CFS, not to package the extension. Keeping the PR path focused avoids unrelated packaging failures without changing the normal main build.

Validation

  • YAML parses successfully
  • build 32039555 completed the CFS-authenticated npm install, Maven/Tycho build, and extension prepublish before failing at the now-excluded VSIX packaging step

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The YAML changes cleanly isolate PR validation to the intended CFS-backed restore/build steps without impacting the existing non-PR build and packaging flow.

Pull request overview

This PR updates the Azure DevOps CI pipeline to make pull request validation focus exclusively on verifying that npm and Maven/Tycho dependencies can be restored and built through CFS, while keeping the existing full build + packaging pipeline behavior for non-PR runs (including main).

Changes:

  • Adds a PR-only CFSValidation job that runs CFS-backed npm restore and Maven/Tycho build steps.
  • Skips linting, vscode:prepublish, VSIX packaging (vsce package), and artifact publication for PR runs.
  • Expands PR path filters so validation triggers when dependency inputs or CFS pipeline configuration files change.
File summaries
File Description
.azure-pipelines/vscode-java-test-ci.yml Introduces a PR-only CFS validation job and gates the existing full CI job to non-PR runs; broadens PR path filters to include CFS-related pipeline inputs.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@wenytang-ms
wenyt (wenytang-ms) merged commit 91bf8ef into main Sep 10, 2026
11 checks passed
@wenytang-ms
wenyt (wenytang-ms) deleted the build/cfs-restore-only-pr-validation branch September 10, 2026 05:18

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The pipeline conditions and path filters appear consistent with the stated goal of limiting PR validation to CFS-backed restore/build steps while preserving full non-PR behavior.

Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants